Tidy up syntax for passing additional parameters

[mszostok]

Description

Changed syntax

1. Policy changes:

   • Changed syntax from map to list to unify syntax with additionalTypeInstances and requiredTypeInstances

   • Renamed inject.additionalInput to inject.additionalParameters

   • The name was previously hardcoded to additional-parameters

   • New feature: Support multiple input parameters on Implementation

     Before	After
     inject: additionalInput: additional-parameters: replicaCount: 3	inject: additionalParameters: - name: rds-parameters value: replicaCount: 3

2. Implementation OCF changes:

   • Require parameter name same as we have for additional TypeInstances

     Before	After
     additionalInput: parameters: typeRef: path: cap.type.aws.rds.install-input revision: 0.1.0	additionalInput: parameters: rds-parameters: typeRef: path: cap.type.aws.rds.install-input revision: 0.1.0

Changes proposed in this pull request:

• API:
  • Update Policy schema
  • GraphQL
  • OCF Schemas
• Policy merger
• Support new syntax in DB Populator
• Renderer test: https://github.com/capactio/capact/pull/450/files#diff-0b6118f26854d2b44aa5e0c99e85ccffa7e2d5d2406186034799c94d9a977a12R229-R235.

Out of scope:

• Additional coverage for TestResolveTypeRefsToJSONSchemasFailures (non happy path) - thanks to that I found bug that we ignored errors in non-happy path.
• Additional coverage for TestValidateImplementationParameters
• Fix bug in db populator. We ignored required verbs for additionalInput.typeInstances,
  • error: #1: graphql: Cannot return null for non-nullable field InputTypeInstance.verbs.
  • query for debugging:

     MATCH (n:InputTypeInstance)<-[:CONTAINS]-(impl:ImplementationAdditionalInput)<-[:USES]-(spec: ImplementationSpec)<-[:SPECIFIED_BY]-(rev: ImplementationRevision)-[:DESCRIBED_BY]->(meta: ImplementationMetadata)  RETURN n.name, n.verbs, n, rev, meta

    
    Here is diff, tbh I don't understand why GH doesn't show this change: 64f556a#diff-81d3dd9650f4d66d745d9ccb905dbc589f1b0e46483c9c24367960cb060b5b2bR317-R318
• Create policy always when necessary: Fix creating Action Policy, replace gotest.tools with testify and unify cmds naming #457

Testing

1. Checkout PR, and create cluster make dev-cluster.

2. Update Global Policy via GraphQL:

   capact/pkg/engine/api/graphql/examples.graphql

   Lines 165 to 214 in 64f556a

   	mutation UpdatePolicy {
   	updatePolicy(
   	in: {
   	rules: [
   	{
   	interface: {
   	path: "cap.interface.capactio.capact.validation.hub.install"
   	}
   	oneOf: [
   	{
   	implementationConstraints: {
   	path: "cap.implementation.capactio.capact.validation.io.install"
   	}
   	inject: {
   	additionalParameters: [
   	{
   	name: "mattermost-parameters"
   	value: { revisionHistoryLimit: 123 }
   	}
   	{
   	name: "rocketchat-parameters"
   	value: { replicaCount: 3 }
   	}
   	]
   	}
   	}
   	{
   	implementationConstraints: {
   	requires: { path: "cap.core.type.platform.kubernetes" }
   	}
   	}
   	]
   	}
   	{
   	interface: { path: "cap.*" }
   	oneOf: [
   	{
   	implementationConstraints: {
   	requires: { path: "cap.core.type.platform.kubernetes" }
   	}
   	}
   	{}
   	]
   	}
   	]
   	}
   	) {
   	...PolicyFields
   	}
   	}

   1. or Capact CLI:

   cat > /tmp/policy.yaml << ENDOFFILE
   rules:
     - interface:
         path: "cap.interface.capactio.capact.validation.hub.install"
       oneOf:
         - implementationConstraints:
             path: "cap.implementation.capactio.capact.validation.io.install"
           inject:
             additionalParameters:
               - name: mattermost-parameters
                 value:
                   revisionHistoryLimit: 123
               - name: rocketchat-parameters
                 value:
                   replicaCount: 3
   
     - interface:
         path: cap.*
       oneOf:
         - implementationConstraints:
             requires:
               - path: "cap.core.type.platform.kubernetes"
         - implementationConstraints: {} # fallback to any Implementation
   ENDOFFILE
   
   capact policy apply -f /tmp/policy.yaml

3. Create Action Policy:

   cat <<EOF > /tmp/act-policy.yaml
   rules:
     - interface:
         path: cap.interface.capactio.capact.validation.hub.install
       oneOf:
         - implementationConstraints:
             path: "cap.implementation.capactio.capact.validation.io.install"
           inject:
             additionalParameters:
               - name: "mattermost-parameters"
                 value:
                   replicaCount: 3
               - name: "rocketchat-parameters"
                 value:
                   replicaCount: 5
   EOF

4. Create Action with the given policy via Capact CLI:

   capact act create cap.interface.capactio.capact.validation.hub.install --name test --action-policy-from-file /tmp/act-policy.yaml

5. Wait until READY_TO_RUN: watch -n 1 capact action get test

6. Run Action: capact act run test

7. Watch Action : capact act watch test

8. Check logs argo logs test -n default.
   Expected, that the mattermost-parameters values are merged, and rocketchat-parameters has overwritten replicaCount.

   Example:

   test-2994129991: optional postgresql TypeInstance was not specified
   test-3931835117: cat /mattermost-parameters.yaml
   test-3931835117: replicaCount: 3
   test-3931835117: revisionHistoryLimit: 123
   test-3931835117: cat /rocketchat-parameters.yaml
   test-3931835117: replicaCount: 5

Related issue(s)

• Rework Policy engine to support additionalTypeInstances and tidy up syntax #438

[mszostok]

FYI: I will update our generator or we will update it here: #447
Depends what will be first.

[pkosiec]

LGTM, works like a charm. Just a few really minor comments.