Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inlineDeclarations default bug #448

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kulliax
Copy link

@kulliax kulliax commented Dec 19, 2024

fix #447

@daogrady
Copy link
Contributor

Thank you for providing a PR.
I am actually unsure if we shouldn't instead just adjust the help text, seeing that changing the default value is a breaking change.

@kulliax
Copy link
Author

kulliax commented Dec 19, 2024

Hi @daogrady
I can't answer that. The error came with the last update, before that we also used the structured type as standard without specification. I didn't realise that this could be controlled in the options. If I see this correctly, it has been introduced here:

- [breaking] when running cds-typer in a CAP project, the default for the `outputDirectory` option will be `./@cds-models` instead of `./`. This default takes the lowest precedence after setting it in the project's `cds.env`, or explicitly as CLI argument.

Previously we were on 0.29.0, see: #405

EDIT: I just saw that it was apparently on flat before: https://github.com/cap-js/cds-typer/pull/416/files Unfortunately I don't have access to our code at the moment to check the options again.

@daogrady
Copy link
Contributor

I see, is the behaviour of cds-typer now as you would expect it when you use your fix?

@kulliax
Copy link
Author

kulliax commented Dec 19, 2024

In our last build, we set the option in package.json to structured. It then ran successfully. I am open whether you change this in the help or in the default values. Perhaps you should check again in which version the standard was changed from structured to flat.

@kulliax
Copy link
Author

kulliax commented Dec 19, 2024

43d6269

as I can see, it has been flat since at least september. then the value in the help is the better option. We didn't adjust the dependencies for a while because they were causing other problems.

Thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in help command lead to problems in cds build
2 participants