Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in help command lead to problems in cds build #447

Open
kulliax opened this issue Dec 19, 2024 · 1 comment · May be fixed by #448
Open

Bug in help command lead to problems in cds build #447

kulliax opened this issue Dec 19, 2024 · 1 comment · May be fixed by #448

Comments

@kulliax
Copy link

kulliax commented Dec 19, 2024

Default values are different:

cds-typer/lib/visitor.js

Lines 65 to 68 in bcb1181

this.inlineDeclarationResolver =
configuration.inlineDeclarations === 'structured'
? new StructuredInlineDeclarationResolver(this)
: new FlatInlineDeclarationResolver(this)

cds-typer/lib/cli.js

Lines 182 to 186 in bcb1181

inlineDeclarations: {
desc: `Whether to resolve inline type declarations${EOL}flat: (x_a, x_b, ...)${EOL}or structured: (x: {a, b}).`,
allowed: ['flat', 'structured'],
default: 'structured'
},

@kulliax kulliax linked a pull request Dec 19, 2024 that will close this issue
@daogrady
Copy link
Contributor

Hi @kulliax ,

thanks for reporting this issue. I will adjust the default value for inline_declarations to be in line with the help text.
For future reports, please stick to the issue template and fill in all the required information. Thanks.

Best,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants