Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(/kubernetes/resources): Rebranding #14665

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Jan 21, 2025

Done

  • Rebrands /kubernetes/resources based on the copydoc and figma design
  • Creates a new macro _macros-resource.jinja to help handle the build of the individual resource. My thinking here is that it will be a lot easier to update the content and make changes to the design

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12887

@webteam-app
Copy link

@mattea-turic
Copy link
Collaborator

Looks good, thanks @petesfrench !
A couple of small comments:

  • On smaller screens, the horizontal line under the tabs doesn't extend to occupy the whole width of the tabs
  • Ik you mentioned on MM that 'title' and 'date & author' switch – I'm guessing this hierarchy is a workaround till it can be fixed? I think it works, but it's still not a common way of structuring content and might be a lil confusing for users to not see the heading first

@petesfrench
Copy link
Contributor Author

petesfrench commented Jan 21, 2025

Looks good, thanks @petesfrench ! A couple of small comments:

  • On smaller screens, the horizontal line under the tabs doesn't extend to occupy the whole width of the tabs

I have created an issue against the vanilla repo to address this separately

  • Ik you mentioned on MM that 'title' and 'date & author' switch – I'm guessing this hierarchy is a workaround till it can be fixed? I think it works, but it's still not a common way of structuring content and might be a lil confusing for users to not see the heading first

So I have been doing a bit of research into this case, as it require duplicating content within the page. This of course won't be visible to users. but will be visible to web crawlers. This may have a negative effect on the SEO performance of the page.

I am going to implement it this time, but it is something we need to look further into moving forward.

@eliman11
Copy link

eliman11 commented Jan 21, 2025

Thanks @petesfrench! Just have a few minor copy updates:

  • Author for "Containers-as-a-service: deploy faster with Canonical and Portainer" should be Alex Chalkias and dated 23 September 2021
  • Author for "Deliver your software with Kubernetes" should be Alex Chalkias, Mark Lewis and dated 7 March 2022
  • "Micro clouds: Secure container orchestration at the edge" should be dated 3 March 2021
  • Change to US spelling: organisations -> organizations in "Many organisations are using managed services for commodity operations to free up their resources for more strategic activities."

@eliman11
Copy link

Thanks for the quick change @petesfrench! Sorry just noticed one super minor thing - the aria-label for the author links in "Introduction to bare-metal cloud with Kubernetes and MAAS" is missing the author name. Adding UX+1 though!

@mattea-turic
Copy link
Collaborator

Thank you @petesfrench ! The design itself is good, but apparently I can't read so ended up adding wrong authors for a few of the blog posts. I've added replacement assets here:
"Containers-as-a-service: deploy faster..."
"Deliver your software with Kubernetes"
"Micro clouds: Secure container orchestration..."

I'll +1 as I trust nothing will go wrong following this

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor comments:

templates/kubernetes/resources.html Outdated Show resolved Hide resolved
templates/kubernetes/resources.html Outdated Show resolved Hide resolved
templates/kubernetes/resources.html Show resolved Hide resolved
templates/kubernetes/resources.html Show resolved Hide resolved
templates/kubernetes/resources.html Outdated Show resolved Hide resolved
templates/kubernetes/resources.html Outdated Show resolved Hide resolved
@petesfrench petesfrench merged commit cec2d01 into k8s-bubble-refresh Jan 22, 2025
25 checks passed
@petesfrench petesfrench deleted the wd-12887 branch January 22, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants