-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(/kubernetes/resources): Rebranding #14665
Conversation
Looks good, thanks @petesfrench !
|
I have created an issue against the vanilla repo to address this separately
So I have been doing a bit of research into this case, as it require duplicating content within the page. This of course won't be visible to users. but will be visible to web crawlers. This may have a negative effect on the SEO performance of the page. I am going to implement it this time, but it is something we need to look further into moving forward. |
Thanks @petesfrench! Just have a few minor copy updates:
|
Thanks for the quick change @petesfrench! Sorry just noticed one super minor thing - the aria-label for the author links in "Introduction to bare-metal cloud with Kubernetes and MAAS" is missing the author name. Adding UX+1 though! |
Thank you @petesfrench ! The design itself is good, but apparently I can't read so ended up adding wrong authors for a few of the blog posts. I've added replacement assets here: I'll +1 as I trust nothing will go wrong following this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few minor comments:
Done
_macros-resource.jinja
to help handle the build of the individual resource. My thinking here is that it will be a lot easier to update the content and make changes to the designQA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-12887