Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-8881 - page refresh /pricing/devices #13622

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

lizzochek
Copy link
Contributor

@lizzochek lizzochek commented Feb 28, 2024

Done

Update /pricing/devices page according to copy doc

QA

  • demo link
  • copy doc
  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8001/
  • Run through the following QA steps
  • Check that the page is correctly updated according to copy doc

Issue / Card

WD-8881

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13622.demos.haus

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (81eb1db) to head (6e990e0).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13622      +/-   ##
==========================================
+ Coverage   74.41%   74.46%   +0.04%     
==========================================
  Files         107      107              
  Lines        2838     2847       +9     
  Branches      946      948       +2     
==========================================
+ Hits         2112     2120       +8     
- Misses        702      703       +1     
  Partials       24       24              

see 1 file with indirect coverage changes

@Sophie-32
Copy link

Tagged @lizzochek in one comment on the copydoc to check order of one set of cards.

chillkang

This comment was marked as duplicate.

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more questions, minor comments:

templates/pricing/devices.html Outdated Show resolved Hide resolved
templates/pricing/devices.html Outdated Show resolved Hide resolved
templates/pricing/devices.html Outdated Show resolved Hide resolved
Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizzochek lizzochek merged commit 8170e67 into canonical:main Mar 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants