Allow to login in the newly created session after setup #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenvandine
requested changes
Sep 22, 2023
packages/ubuntu_init/lib/src/launchsession/launchsession_page.dart
Outdated
Show resolved
Hide resolved
packages/ubuntu_init/lib/src/launchsession/launchsession_page.dart
Outdated
Show resolved
Hide resolved
packages/ubuntu_init/lib/src/launchsession/launchsession_page.dart
Outdated
Show resolved
Hide resolved
packages/ubuntu_init/lib/src/launchsession/launchsession_page.dart
Outdated
Show resolved
Hide resolved
|
Changed the launchsession page to mimic the one in gnome-initial-setup.
|
|
I don't know what is happening with github... the "git push" command doesn't work. |
|
Uploaded. |
|
Rebased to fix the conflicts. |
sergio-costas
force-pushed
the
add-login-on-end
branch
from
431f461 to
312f42d
Compare
kenvandine
reviewed
Sep 27, 2023
| "@launchsessionTitle": {}, | ||
| "launchsessionHeader": "All done!", | ||
| "@launchsessionHeader": {}, | ||
| "launchsessionDescription": "You can now begin using Ubuntu Core Desktop.", |
There was a problem hiding this comment.
This is fine for now, but eventually we want to detect the OS identifier from /etc/os-release. But that's still an outstanding item we need to resolve on the core22-desktop side first.
d-loose
reviewed
Sep 28, 2023
d-loose
reviewed
Sep 28, 2023
d-loose
reviewed
Sep 28, 2023
d-loose
reviewed
Sep 28, 2023
d-loose
reviewed
Sep 28, 2023
d-loose
reviewed
Sep 28, 2023
sergio-costas
force-pushed
the
add-login-on-end
branch
from
e6221a7 to
2a4d735
Compare
sergio-costas
force-pushed
the
add-login-on-end
branch
from
5775a8f to
3b6897f
Compare
kenvandine
approved these changes
Oct 2, 2023
|
@kenvandine I misunderstood the comment from Robert at his dbus.dart branch; anyway, I tested it and the code does work with the current code in main, so that branch doesn't need to be merged. Also, I had to revert a change that I did, because it is needed to "reuse" the GDM connection for the greeter and the user verifier. |
This PR adds an extra page that can be used at the end for login into the newly created session.
This patch uses DBus to launch a Gnome Shell session after the setup has been completed. It requires the last changes to the DBus module to support point-to-point DBus communication over a custom unix socket.
- moving GdmService into a true service - encapsulate getting the username and password into GdmService - return the Store page
It is a must to re-use the GDM connection to ensure that launching the new session does work. Also, the branch from Robert Ancell is not needed anymore; with the current code in the main branch is enough.
sergio-costas
force-pushed
the
add-login-on-end
branch
from
875f37f to
b102dba
Compare
This reverts commit 944d82e.
sergio-costas
force-pushed
the
add-login-on-end
branch
3 times, most recently
from
9faec18 to
6a2a8a1
Compare
|
Yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new final page to ubuntu_init where the button to launch the store is removed (since it doesn't work on core desktop) and that launches the newly created session by calling GDM.
This patch requires the patches for dbus.dart that implements support for point-to-point dbus connections: canonical/dbus.dart#363