re-use connection and use main code for dbus

It is a must to re-use the GDM connection to ensure that
launching the new session does work.

Also, the branch from Robert Ancell is not needed anymore; with
the current code in the main branch is enough.

packages/ubuntu_bootstrap/pubspec.yaml

@@ -90,5 +90,4 @@ flutter:
 dependency_overrides:
   dbus:
     git:
-      url: https://github.com/robert-ancell/dbus.dart.git
-      ref: client-no-hello
+      url: https://github.com/canonical/dbus.dart.git

packages/ubuntu_init/pubspec.yaml

@@ -68,5 +68,4 @@ flutter:
 dependency_overrides:
   dbus:
     git:
-      url: https://github.com/robert-ancell/dbus.dart.git
-      ref: client-no-hello
+      url: https://github.com/canonical/dbus.dart.git

packages/ubuntu_provision/lib/src/services/gdm_service.dart

@@ -10,23 +10,31 @@ final log = Logger('dart_gdm_service');
 
 class GdmService {
   bool _testing = false;
+  DBusClient? gdmClient;
 
   void setTesting() {
     _testing = true;
   }
 
   Future<DBusClient> getClientConnection() async {
-    var gdmObject = DBusRemoteObject(DBusClient.system(),
-        name: 'org.gnome.DisplayManager',
-        path: DBusObjectPath('/org/gnome/DisplayManager/Manager'));
-    var response = await gdmObject.callMethod(
-        'org.gnome.DisplayManager.Manager', 'OpenSession', [],
-        replySignature: DBusSignature('s'));
-    var address = response.values[0].asString();
-    return DBusClient(DBusAddress(address), messageBus: false);
+    if (gdmClient == null) {
+      log.info('Asking for GDM connection');
+      var gdmObject = DBusRemoteObject(DBusClient.system(),
+          name: 'org.gnome.DisplayManager',
+          path: DBusObjectPath('/org/gnome/DisplayManager/Manager'));
+      var response = await gdmObject.callMethod(
+          'org.gnome.DisplayManager.Manager', 'OpenSession', [],
+          replySignature: DBusSignature('s'));
+      var address = response.values[0].asString();
+      gdmClient = DBusClient(DBusAddress(address), messageBus: false);
+    } else {
+      log.info('Re-using GDM connection');
+    }
+    return gdmClient!;
   }
 
   Future<DBusRemoteObject> getGreeter() async {
+    log.info('Getting Greeter GDM connection');
     var connection = await getClientConnection();
     var greeter = DBusRemoteObject(connection,
         name: 'org.gnome.DisplayManager.Greeter',
@@ -35,6 +43,7 @@ class GdmService {
   }
 
   Future<DBusRemoteObject> getUserVerifier() async {
+    log.info('Getting User Verifier GDM connection');
     var connection = await getClientConnection();
     var userVerifier = DBusRemoteObject(connection,
         name: 'org.gnome.DisplayManager.UserVerifier',
@@ -83,7 +92,7 @@ class GdmService {
     infoQuerySignal
         .listen((signal) => log.info('InfoQuery signal received $signal'));
     problemSignal
-        .listen((signal) => log.info('Problem signal received $signal'));
+        .listen((signal) => log.warning('Problem signal received $signal'));
     secretInfoQuerySignal.listen((signal) {
       log.info('SecretInfoQuery signal received $signal');
       unawaited(userVerifier.callMethod(
@@ -98,6 +107,7 @@ class GdmService {
       completer.complete();
     });
 
+    log.info('Starting user verification');
     unawaited(userVerifier.callMethod(
         'org.gnome.DisplayManager.UserVerifier',
         'BeginVerificationForUser',

packages/ubuntu_provision/pubspec.yaml

@@ -70,5 +70,4 @@ flutter:
 dependency_overrides:
   dbus:
     git:
-      url: https://github.com/robert-ancell/dbus.dart.git
-      ref: client-no-hello
+      url: https://github.com/canonical/dbus.dart.git

packages/ubuntu_provision_test/pubspec.yaml

@@ -35,5 +35,4 @@ dependencies:
 dependency_overrides:
   dbus:
     git:
-      url: https://github.com/robert-ancell/dbus.dart.git
-      ref: client-no-hello
+      url: https://github.com/canonical/dbus.dart.git