-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow clients and servers to operate without names #363
Conversation
b9ee7f3
to
dff3495
Compare
…ing D-Bus for a simple client-server relationship and not in the more common client-client. This only supports method calls from the client to the server at present.
dff3495
to
e6c4c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll try to test this with my code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It begins to work, but still triggers a new exception:
flutter: ERROR ubuntu_init: Unhandled exception
DBusUnknownMethodException: org.freedesktop.DBus.Error.UnknownMethod: No such method “GetNameOwner”
#0 DBusClient._callMethod (package:dbus/src/dbus_client.dart:1121)
<asynchronous suspension>
#1 DBusClient.callMethod (package:dbus/src/dbus_client.dart:617)
<asynchronous suspension>
#2 DBusClient.getNameOwner (package:dbus/src/dbus_client.dart:457)
<asynchronous suspension>
#3 DBusClient._findUniqueName (package:dbus/src/dbus_client.dart:633)
The problem seems to be when creating a DBusRemoteObjectSignal object, to receive signals. |
86e6488
to
9d7ae4a
Compare
I think this branch should be able to receive signals now, though I haven't tested it. I'm landing some structural changes on main then I'll being these over after. |
In fact, I think this should now work from main, I haven't got a test for the method calls there because I'm not sure the best way to expose them server side, but the code should support both methods and signals. |
It would be good to have a test case matching what @sergio-costas is doing. |
@robert-ancell I'll test this right now. Thanks! |
This code works great, it talks flawlessly with GDM, and opens the new session perfectly. Thanks!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
Is everything you need working on main? This PR is too difficult to merge back, I'll look at adding any missing features in a separate PR. |
@robert-ancell Yes, everything works like a charm. |
@robert-ancell Agh, sorry! I didn't read the "in main" part, and I presumed that you was asking if this patch had everything that I needed.. I'll check if it does work. |
Ok, I tested it with the code from the main branch of https://github.com/canonical/dbus.dart.git, and it works fine. |
Allow clients and servers to operate without names, for example if using D-Bus
for a simple client-server relationship and not in the more common client-client.
This only supports method calls from the client to the server at present.