Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: catch craft-provider errors #4419

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 23, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Cherry-pick the bugfix in #4295 onto hotfix/7.5

Related to #429
(CRAFT-2174)

Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 23, 2023

Blocked by #4420

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #4419 (63f2d79) into hotfix/7.5 (7cd7cba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           hotfix/7.5    #4419   +/-   ##
===========================================
  Coverage       94.88%   94.88%           
===========================================
  Files             658      658           
  Lines           55162    55176   +14     
===========================================
+ Hits            52341    52355   +14     
  Misses           2821     2821           
Files Coverage Δ
snapcraft/cli.py 82.69% <100.00%> (+0.69%) ⬆️
tests/unit/cli/test_exit.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit 6b2f6d2 into hotfix/7.5 Oct 24, 2023
@mr-cal mr-cal deleted the craft-provider-errors-hotfix branch October 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants