Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: catch craft-provider errors #4295

Merged
merged 1 commit into from
Jul 26, 2023
Merged

cli: catch craft-provider errors #4295

merged 1 commit into from
Jul 26, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jul 26, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Resolves #4262

(CRAFT-1898)

Signed-off-by: Callahan Kovacs <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #4295 (0815ce5) into main (dbe76f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4295   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files         296      296           
  Lines       20208    20212    +4     
=======================================
+ Hits        17984    17988    +4     
  Misses       2224     2224           
Files Changed Coverage Δ
snapcraft/cli.py 83.49% <100.00%> (+0.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit 5110612 into main Jul 26, 2023
@sergiusens sergiusens deleted the craft-providers-errors branch July 26, 2023 23:03
@mr-cal mr-cal mentioned this pull request Oct 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LXD errors from Craft Providers not properly presented
3 participants