Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: update craft-parts to 1.19.7 #4305

Merged

Conversation

cmatsuoka
Copy link
Contributor

Craft Parts 1.19.7 addresses issues related to version being set
twice during rebuilds.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@cmatsuoka
Copy link
Contributor Author

@kubiko Could you test kernel builds with this change to ensure it works as expected?

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #4305 (a1ca690) into hotfix/7.5 (d22913b) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           hotfix/7.5    #4305   +/-   ##
===========================================
  Coverage       94.88%   94.88%           
===========================================
  Files             657      657           
  Lines           55116    55116           
===========================================
  Hits            52297    52297           
  Misses           2819     2819           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@kubiko kubiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me
I have tested this with some of the kernel snaps which were failing before and snap built successfully.

cmatsuoka and others added 4 commits August 9, 2023 14:48
Craft Parts 1.19.7 addresses issues related to version being set
twice during rebuilds.

Signed-off-by: Claudio Matsuoka <[email protected]>
@cmatsuoka cmatsuoka force-pushed the craft-1088/update-craft-parts branch from 4aab79f to a1ca690 Compare August 9, 2023 17:48
@cmatsuoka
Copy link
Contributor Author

Rebased on top of hotfix/7.5.

@cmatsuoka cmatsuoka marked this pull request as ready for review August 9, 2023 17:49
@cmatsuoka cmatsuoka removed the squash label Aug 9, 2023
@cmatsuoka cmatsuoka marked this pull request as draft August 9, 2023 18:10
@cmatsuoka cmatsuoka marked this pull request as ready for review August 9, 2023 18:21
@cmatsuoka cmatsuoka merged commit 24e430d into canonical:hotfix/7.5 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants