-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements: update craft-parts to 1.19.7 #4305
requirements: update craft-parts to 1.19.7 #4305
Conversation
@kubiko Could you test kernel builds with this change to ensure it works as expected? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## hotfix/7.5 #4305 +/- ##
===========================================
Coverage 94.88% 94.88%
===========================================
Files 657 657
Lines 55116 55116
===========================================
Hits 52297 52297
Misses 2819 2819 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me
I have tested this with some of the kernel snaps which were failing before and snap built successfully.
Craft Parts 1.19.7 addresses issues related to version being set twice during rebuilds. Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
4aab79f
to
a1ca690
Compare
Rebased on top of hotfix/7.5. |
Craft Parts 1.19.7 addresses issues related to version being set
twice during rebuilds.
make lint
?pytest tests/unit
?