Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros: make linter tests more flexible #4223

Merged
merged 2 commits into from
Jun 19, 2023
Merged

ros: make linter tests more flexible #4223

merged 2 commits into from
Jun 19, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 19, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Adds some flexibility to the linter-ros2-humble-mixed spread test, which has been failing due to a set of 7 libraries appearing and disappearing from the list of unused libraries:

Signed-off-by: Callahan Kovacs <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Merging #4223 (4f2efca) into main (421fd64) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4223   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files         569      569           
  Lines       43746    43746           
=======================================
  Hits        41078    41078           
  Misses       2668     2668           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal enabled auto-merge (squash) June 19, 2023 21:59
@mr-cal mr-cal merged commit 64c8f1e into main Jun 19, 2023
@mr-cal mr-cal deleted the ros-linter-fix branch June 19, 2023 22:39
@mr-cal mr-cal mentioned this pull request Jun 20, 2023
4 tasks
cmatsuoka pushed a commit to cmatsuoka/snapcraft that referenced this pull request Aug 4, 2023
cmatsuoka pushed a commit to cmatsuoka/snapcraft that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants