Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5318] update user management #329

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Sep 9, 2024

Issue:

  1. Users created by clients get automatically deleted by MongoDB charm
  2. Users for mongos K8s charm get automatically deleted by MongoDB charm

Solution:

Keep track of which users the charm should manage and only remove/update those users by bringing over k8s lib

Testing

Lib tested for all charms that use it i.e. MongoDB VM+K8s and Mongos K8s

@MiaAltieri MiaAltieri force-pushed the DPE-5318-update-user-management branch from 2b80dc2 to 6341395 Compare September 9, 2024 16:01
Copy link
Contributor

@Gu1nness Gu1nness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to include this PR in #328 ? Because this is basically the same code, you add a few more changes but it could fit in the same PR?

lib/charms/mongodb/v1/mongodb_provider.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@MiaAltieri MiaAltieri merged commit 7911c38 into 6/edge Sep 11, 2024
22 of 24 checks passed
@MiaAltieri MiaAltieri deleted the DPE-5318-update-user-management branch September 11, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants