Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-5215] Upgrade libraries to fix secret disclosure issue #328

Merged
merged 2 commits into from
Sep 11, 2024
Merged

[DPE-5215] Upgrade libraries to fix secret disclosure issue #328

merged 2 commits into from
Sep 11, 2024

Conversation

Gu1nness
Copy link
Contributor

@Gu1nness Gu1nness commented Sep 9, 2024

Problem

  • We were using the DatabaseProvider class wrong
  • This lead to a secret disclosure issue with mongo-k8s

Solution

Miscellaneous

  • Fix db_initialised property

MiaAltieri
MiaAltieri previously approved these changes Sep 9, 2024
View reviewed changes
MiaAltieri
MiaAltieri previously approved these changes Sep 9, 2024
View reviewed changes
MiaAltieri
MiaAltieri reviewed Sep 9, 2024
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
@Gu1nness Gu1nness mentioned this pull request Sep 10, 2024
Merged
MiaAltieri
MiaAltieri previously approved these changes Sep 10, 2024
View reviewed changes
@Gu1nness Gu1nness merged commit 675e66e into 6/edge Sep 11, 2024
23 of 24 checks passed
@Gu1nness Gu1nness deleted the DPE-5215-secret-data-is-shown branch September 11, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@MiaAltieri MiaAltieri MiaAltieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gu1nness @MiaAltieri @Mehdi-Bendriss