Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorials key errors #117

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Nov 30, 2021

Done

  • Fix tutorials key errors
  • Created a source of truth with a list of allowed maps

QA

Use this PR

Issue

Fixes #111

@carkod carkod force-pushed the fix-tutorials-keyerrors branch 7 times, most recently from fea187a to f3a0c6a Compare November 30, 2021 18:20
@carkod carkod force-pushed the fix-tutorials-keyerrors branch 4 times, most recently from e223052 to ef1423e Compare December 1, 2021 17:17
@carkod carkod assigned carkod and unassigned carkod Dec 1, 2021
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carkod carkod force-pushed the fix-tutorials-keyerrors branch from ef1423e to c98711e Compare December 3, 2021 09:59
@carkod carkod merged commit 97b403f into canonical:main Dec 6, 2021
@carkod carkod deleted the fix-tutorials-keyerrors branch December 6, 2021 10:13
carkod added a commit to carkod/canonicalwebteam.discourse that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial keys with typos cause 500s
2 participants