Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial key error issues #10971

Closed
wants to merge 1 commit into from

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Nov 30, 2021

For testing canonical/canonicalwebteam.discourse#117

Done

  • [List of work items including drive-bys - remember to add the why and what of this work.]

QA

  • Checkout this branch
  • dotrun clean && dotrun to make sure you get PR#117 from canonicalwebteam.discourse
  • check /tutorials to see the errors. These tutorials are test tutorials that use an index topic that contains errors. Feel free to suggest a better error message (I didn't give it much thought) or play around breaking the keys.

Issue / Card

Fixes #

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@carkod carkod force-pushed the fix-tutorial-keyerrors branch from d5a513c to 54750cf Compare November 30, 2021 18:22
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #10971 (54750cf) into main (f95e283) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10971   +/-   ##
=======================================
  Coverage   61.02%   61.02%           
=======================================
  Files         100      100           
  Lines        2381     2381           
  Branches      652      652           
=======================================
  Hits         1453     1453           
  Misses        869      869           
  Partials       59       59           

@carkod
Copy link
Contributor Author

carkod commented Dec 12, 2021

Sending errors for now to Sentry instead of displaying on the site

@carkod carkod closed this Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant