Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to use shutdown gateways #116

Merged
merged 3 commits into from
Feb 22, 2022
Merged

fix: don't try to use shutdown gateways #116

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f7ec7e
fix: don't use shutdown gateways
lenaschoenburg Feb 22, 2022
2c93ece
fix: quote to prevent word splitting
lenaschoenburg Feb 22, 2022
0797e3f
fix: use word splitting for labels
lenaschoenburg Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions chaos-workers/chaos-experiments/scripts/utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function runOnAllBrokers()
{
namespace=$(getNamespace)

pods=$(kubectl get pod -n "$namespace" $(getBrokerLabels) -o jsonpath="{.items[*].metadata.name}")
pods=$(kubectl get pod -n "$namespace" "$(getBrokerLabels)" -o jsonpath="{.items[*].metadata.name}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ this quoating doesn't work here. We want to have multiple labels here, splitted. Either we ignore this shellcheck error or we implement this differently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, of course 🤦 I'll add an ignore instead.


set +e
for pod in $pods
Expand All @@ -53,15 +53,15 @@ function getBroker()
index=${1:-0}

namespace=$(getNamespace)
pod=$(kubectl get pod -n "$namespace" $(getBrokerLabels) -o jsonpath="{.items[$index].metadata.name}")
pod=$(kubectl get pod -n "$namespace" "$(getBrokerLabels)" -o jsonpath="{.items[$index].metadata.name}")

echo "$pod"
}

function getGateway()
{
namespace=$(getNamespace)
pod=$(kubectl get pod -n "$namespace" $(getGatewayLabels) -o jsonpath="{.items[0].metadata.name}")
pod=$(kubectl get pod -n "$namespace" --field-selector status.phase=Running "$(getGatewayLabels)" -o jsonpath="{.items[0].metadata.name}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍


echo "$pod"
}
Expand Down
2 changes: 1 addition & 1 deletion chaos-workers/chaos-experiments/scripts/verify-readiness.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ else
# Wait until all gateway pods are running. We cannot use `--for=condition=Ready` pod for gateway because
# this check also includes the evicted pods as long as they are not deleted. Evicted pods are not immediately
# deleted by kuberenetes. The following check passes only if all pods are running, and excludes evicted pods.
kubectl wait --for=condition=Available deployment $namespace-zeebe-gateway --timeout=120s -n "$namespace"
kubectl wait --for=condition=Available deployment "$namespace-zeebe-gateway" --timeout=120s -n "$namespace"
fi