fix: don't try to use shutdown gateways #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When gateway pods are evicted, they stay around with status "Shutdown". We need to filter for running pods to get a gateway that we can actually use.
ChrisKujawa
requested changes
Feb 22, 2022
| @@ -38,7 +38,7 @@ function runOnAllBrokers() | |||
| { | |||
| namespace=$(getNamespace) | |||
|
|
|||
| pods=$(kubectl get pod -n "$namespace" $(getBrokerLabels) -o jsonpath="{.items[*].metadata.name}") | |||
| pods=$(kubectl get pod -n "$namespace" "$(getBrokerLabels)" -o jsonpath="{.items[*].metadata.name}") | |||
There was a problem hiding this comment.
❌ this quoating doesn't work here. We want to have multiple labels here, splitted. Either we ignore this shellcheck error or we implement this differently.
There was a problem hiding this comment.
Oh, of course 🤦 I'll add an ignore instead.
|
|
||
| echo "$pod" | ||
| } | ||
|
|
||
| function getGateway() | ||
| { | ||
| namespace=$(getNamespace) | ||
| pod=$(kubectl get pod -n "$namespace" $(getGatewayLabels) -o jsonpath="{.items[0].metadata.name}") | ||
| pod=$(kubectl get pod -n "$namespace" --field-selector status.phase=Running "$(getGatewayLabels)" -o jsonpath="{.items[0].metadata.name}") |
labels actually need to be split on whitespace, so we disable the shellcheck instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gateway pods are evicted, they stay around with status "Shutdown".
We need to filter for running pods to get a gateway that we can actually use.