Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI metadata and server needed to query the background #2263

Merged
merged 2 commits into from
May 24, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions c2cgeoportal/scaffolds/update/CONST_vars.yaml_tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,12 @@ vars:
- wmsLayers
- minResolutionHint
- maxResolutionHint
# WMTS layers
- ogcServer
- layers
- queryLayers
- printLayers


# The list of functionalities that can be configured
# through the admin interface.
Expand Down
7 changes: 4 additions & 3 deletions c2cgeoportal/tests/functional/test_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -1450,14 +1450,16 @@ def test_layer(self):
group1.children = [group2]
group2.children = [layer]

self.assertEqual(entry._group("", group1, [layer.name], wms=None, wms_layers=[], time=TimeInformation()), ({
self.assertEqual(entry._group(
"", group1, [layer.name],
wms=None, wms_layers=[], time=TimeInformation()
), ({
"id": 11,
"isExpanded": False,
"isInternalWMS": True,
"name": "block",
"isBaseLayer": False,
"metadata": {},
"mixed": False,
"children": [{
"id": 12,
"isExpanded": False,
Expand All @@ -1466,7 +1468,6 @@ def test_layer(self):
"isBaseLayer": False,
"metadataURL": "http://example.com/group.metadata",
"metadata": {},
"mixed": False,
"children": [{
"name": "test layer in group",
"id": 20,
Expand Down
71 changes: 71 additions & 0 deletions c2cgeoportal/tests/functional/test_themes.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,77 @@ def test_metadata(self):
}]
)

def test_server_ogc(self):
entry = self._create_entry_obj(params={
"version": "2",
"catalogue": "true",
})
themes = entry.themes()
self.assertEquals(self._get_filtered_errors(themes), set())
print(themes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgotten debug statement

self.assertEquals(
themes["serversOGC"], {
"__test_server_ogc_internal": {
"wtsSupport": False,
"url": "http://localhost/cgi-bin/mapserv?map=/home/travis/build/camptocamp/c2cgeoportal/c2cgeoportal/tests/functional/c2cgeoportal_test.map&",
"isSingleTile": False,
"auth": None,
"urlWfs": "http://localhost/cgi-bin/mapserv?map=/home/travis/build/camptocamp/c2cgeoportal/c2cgeoportal/tests/functional/c2cgeoportal_test.map&",
"type": "mapserver",
"imageType": "image/jpeg",
},
"source for image/jpeg": {
"wtsSupport": True,
"url": "http://localhost/cgi-bin/mapserv?map=/home/travis/build/camptocamp/c2cgeoportal/c2cgeoportal/tests/functional/c2cgeoportal_test.map&",
"isSingleTile": False,
"auth": "main",
"urlWfs": "http://localhost/cgi-bin/mapserv?map=/home/travis/build/camptocamp/c2cgeoportal/c2cgeoportal/tests/functional/c2cgeoportal_test.map&",
"type": "mapserver",
"imageType": "image/jpeg",
},
"__test_server_ogc_external": {
"wtsSupport": False,
"url": "http://wms.geo.admin.ch/",
"isSingleTile": False,
"auth": None,
"urlWfs": "http://wms.geo.admin.ch/",
"type": "mapserver",
"imageType": "image/jpeg",
},
"source for image/png": {
"wtsSupport": True,
"url": "http://localhost/cgi-bin/mapserv?map=/home/travis/build/camptocamp/c2cgeoportal/c2cgeoportal/tests/functional/c2cgeoportal_test.map&",
"isSingleTile": False,
"auth": "main",
"urlWfs": "http://localhost/cgi-bin/mapserv?map=/home/travis/build/camptocamp/c2cgeoportal/c2cgeoportal/tests/functional/c2cgeoportal_test.map&",
"type": "mapserver",
"imageType": "image/png",
}
},
)
self.assertEquals(
[self._only_name(t, "serverOGC") for t in themes["themes"]],
[{
"children": [{
# order is important
"children": [{
"serverOGC": "__test_server_ogc_internal",
}, {
"serverOGC": "__test_server_ogc_external",
}, {
}]
}, {
# order is important
"children": [{
}, {
"serverOGC": "__test_server_ogc_internal",
}, {
"serverOGC": "__test_server_ogc_external",
}]
}]
}]
)

def test_dimensions(self):
entry = self._create_entry_obj(params={
"version": "2",
Expand Down
77 changes: 55 additions & 22 deletions c2cgeoportal/views/entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
from c2cgeoportal.lib.wmstparsing import parse_extent, TimeInformation
from c2cgeoportal.lib.email_ import send_email
from c2cgeoportal.models import DBSession, User, Role, \
Theme, LayerGroup, RestrictionArea, Interface, \
Theme, LayerGroup, RestrictionArea, Interface, ServerOGC, \
Layer, LayerV1, LayerWMS, LayerWMTS, FullTextSearch


Expand Down Expand Up @@ -237,7 +237,7 @@ def _get_child_layers_info(self, layer):
if hasattr(layer, "queryable") else True
return layer_info

def _layer(self, layer, wms, wms_layers, time, role_id):
def _layer(self, layer, wms, wms_layers, time, role_id, mixed=True):
errors = set()
l = {
"id": layer.id,
Expand Down Expand Up @@ -284,7 +284,7 @@ def _layer(self, layer, wms, wms_layers, time, role_id):
return None, errors
l["type"] = "WMS"
l["layers"] = layer.layer
if not self._fill_wms(l, layer, errors, role_id):
if not self._fill_wms(l, layer, errors, role_id, mixed=mixed):
return None, errors
errors |= self._merge_time(time, l, layer, wms, wms_layers)

Expand Down Expand Up @@ -336,7 +336,7 @@ def _fill_editable(self, l, layer):
if c > 0:
l["editable"] = True

def _fill_wms(self, l, layer, errors, role_id):
def _fill_wms(self, l, layer, errors, role_id, mixed):
wms, wms_layers = self._wms_layers(role_id, layer.server_ogc)

l["imageType"] = layer.server_ogc.image_type
Expand Down Expand Up @@ -383,6 +383,9 @@ def _fill_wms(self, l, layer, errors, role_id):
if len(max_resolutions_hint) > 0:
l["maxResolutionHint"] = max(max_resolutions_hint)

if mixed:
l["serverOGC"] = layer.server_ogc.name
# deprecated
l["url"] = get_url(
layer.server_ogc.url, self.request,
default=self.request.route_url("mapserverproxy"), errors=errors)
Expand All @@ -393,6 +396,7 @@ def _fill_wms(self, l, layer, errors, role_id):
layer.server_ogc.url_wfs, self.request,
default=l["url"], errors=errors)
l["serverType"] = layer.server_ogc.type
# end deprecated

return True

Expand Down Expand Up @@ -562,28 +566,31 @@ def _is_internal_wms(self, layer):
return \
isinstance(layer, LayerV1) and layer.layer_type == "internal WMS"

def _get_layer_identifiers(self, group):
"""Recurse on all children to get unique identifier for each child."""
identifier = []
def _get_ogc_servers(self, group, depth=1):
""" Recurse on all children to get unique identifier for each child. """
ogc_servers = set()

# escape loop
if depth > 30:
log.error("Error: too many recursions with group '%s'" % group.name)
return ogc_servers

# recurse on children
if isinstance(group, LayerGroup) and group.children > 0:
for tree_item in group.children:
child_identifier = self._get_layer_identifiers(tree_item)
identifier = identifier + child_identifier
ogc_servers.update(self._get_ogc_servers(tree_item, depth=depth + 1))

if isinstance(group, LayerWMS):
identifier.append(group.server_ogc_id)
ogc_servers.add(group.server_ogc)

if isinstance(group, LayerWMTS):
# add 2 different values to force the mixed state
identifier = identifier + ["wmts1", "wmts2"]
ogc_servers.add(False)

return identifier
return ogc_servers

def _group(
self, path, group, layers, depth=1, min_levels=1,
catalogue=True, role_id=None, version=1, **kwargs
catalogue=True, role_id=None, version=1, mixed=True, **kwargs
):
children = []
errors = set()
Expand All @@ -595,6 +602,13 @@ def _group(
)
return None, errors

ogc_servers = None
org_depth = depth
if depth == 1:
ogc_servers = list(self._get_ogc_servers(group))
# check if mixed content
mixed = len(ogc_servers) != 1 or ogc_servers[0] is False

for tree_item in group.children:
if type(tree_item) == LayerGroup:
depth += 1
Expand All @@ -603,7 +617,7 @@ def _group(
gp, gp_errors = self._group(
"%s/%s" % (path, tree_item.name),
tree_item, layers, depth=depth, min_levels=min_levels,
catalogue=catalogue, role_id=role_id, version=version, **kwargs
catalogue=catalogue, role_id=role_id, version=version, mixed=mixed, **kwargs
)
errors |= gp_errors
if gp is not None:
Expand All @@ -619,7 +633,7 @@ def _group(
(isinstance(tree_item, LayerV1) and group.is_internal_wms ==
self._is_internal_wms(tree_item))):

l, l_errors = self._layer(tree_item, role_id=role_id, **kwargs)
l, l_errors = self._layer(tree_item, role_id=role_id, mixed=mixed, **kwargs)
errors |= l_errors
if l is not None:
if depth < min_levels:
Expand All @@ -640,7 +654,6 @@ def _group(
"name": group.name,
"children": children,
"metadata": {},
"mixed": False,
}
if version == 1:
g.update({
Expand All @@ -649,11 +662,10 @@ def _group(
"isBaseLayer": group.is_base_layer,
})
else:
# check if mixed content
identifier = self._get_layer_identifiers(group)
# Use set() to remove duplicates
if len(set(identifier)) > 1:
g["mixed"] = True
if org_depth == 1:
g["mixed"] = mixed
if not mixed:
g["serverOGC"] = ogc_servers[0].name

for metadata in group.ui_metadatas:
g["metadata"][metadata.name] = get_url(metadata.value, self.request, errors=errors)
Expand Down Expand Up @@ -1305,6 +1317,27 @@ def themes(self):

result = {}
all_errors = set()
if version == 2:

result["serversOGC"] = {}
for server_ogc in DBSession.query(ServerOGC).all():
url = get_url(
server_ogc.url, self.request,
default=self.request.route_url("mapserverproxy"), errors=all_errors
)
url_wfs = get_url(
server_ogc.url_wfs, self.request,
default=url, errors=all_errors
)
result["serversOGC"][server_ogc.name] = {
"url": url,
"urlWfs": url_wfs,
"type": server_ogc.type,
"imageType": server_ogc.image_type,
"auth": server_ogc.auth,
"wtsSupport": server_ogc.wfs_support,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be wfsSupport.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups, thanks :-)

"isSingleTile": server_ogc.is_single_tile,
}
if export_themes:
themes, errors = self._themes(
role_id, interface, True, version, catalogue, min_levels
Expand Down
39 changes: 35 additions & 4 deletions doc/developer/webservices.rst
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,30 @@ Base for all possible results:
.. code:: json

{
"serversOGC": {
"<name>": <server OGC>
...
}
"themes": [<themes>],
"group": <group>,
"background_layers": [<layers>],
"errors": [<errors>]
}

Server OGC:

.. code:: json

{
"url": "<wms server url>",
"urlWfs": "<wfs server url>",
"wfsSupport": (true|false),
"imageType": "image/(jpeg|png)",
"isSingleTile": (true|false),
"serverType": "(mapserver|geoserver|qgisserver)",
"auth": ""
}


Theme:

Expand All @@ -67,6 +85,16 @@ Group:
{
"name": "<name>",
"mixed": (true|false),
# if not mixed
"serverOGC": {
"url": "<wms server url>",
"wfsUrl": "<wfs server url>",
"wfsSupport": (true|false),
"imageType": "image/(jpeg|png)",
"isSingleTile": (true|false),
"serverType": "(mapserver|geoserver|qgisserver)",
"auth": ""
}
"metadata": {
"<name>": "<value>"
},
Expand All @@ -92,19 +120,22 @@ WMS Layer:
.. code:: json

{

"layers": "<wms_layers>",
"id": <id>,
"name": "<name in tree>",
"layers": "<wms_layers>",
"style": "<style>",
# if not mixed
"serverOGC": "<server name>",
# derecated
"url": "<wms server url>",
"url_wfs": "<wfs server url>",
"wfs_support": (true|false),
"isSingleTile": (true|false),
"id": <id>,
"imageType": "image/(jpeg|png)",
"style": "<style>",
"serverType": "(mapserver|geoserver|qgisserver)",
"minResolutionHint": <minResolutionHint>,
"maxResolutionHint": <maxResolutionHint>,
# end derecated
"metadata": {
"identifier_attribute_field": "<display_name>",
"disclaimer": "<disclamer>",
Expand Down
11 changes: 11 additions & 0 deletions doc/integrator/ngeo.rst
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,14 @@ Background layers

The background layers are configured in the database, with the layer group named
**background** (by default).

WMTS Layers
===========

To make the WMTS queryable you should add those UI Metadata:
``ogcServer`` with the name of the used OGC server,
``layers`` or ``queryLayers`` with the layers to query (groups not supported).

To print the layers in the high quality you you should add those UI Metadata:
``ogcServer`` with the name of the used OGC server,
``layers`` or ``printLayers`` with the layers to print.