Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI metadata and server needed to query the background #2263

Merged
merged 2 commits into from
May 24, 2016
Merged

UI metadata and server needed to query the background #2263

merged 2 commits into from
May 24, 2016

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner added this to the 2.0 milestone May 23, 2016
@sbrunner sbrunner force-pushed the backaground-query branch from 7552830 to f0d138c Compare May 23, 2016 13:42
@sbrunner sbrunner closed this May 23, 2016
@sbrunner sbrunner reopened this May 23, 2016
@sbrunner sbrunner force-pushed the backaground-query branch 5 times, most recently from 209f027 to 0996c39 Compare May 24, 2016 08:48
@sbrunner sbrunner changed the title Backaground query UI metadata and server needed to query the background May 24, 2016
@sbrunner sbrunner force-pushed the backaground-query branch from 19115d8 to c33ebfc Compare May 24, 2016 13:27
@sbrunner
Copy link
Member Author

Wedeay to be reviewed, @fredj can you do it?

fredj
fredj reviewed May 24, 2016
View reviewed changes
c2cgeoportal/views/entry.py

# escape loop
if depth > 30:
print("Error: too many recursions with group '%s'" % group.name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.error ?

@fredj
Copy link
Member

fredj commented May 24, 2016

LGTM

@sbrunner sbrunner force-pushed the backaground-query branch from c33ebfc to 6cc519d Compare May 24, 2016 13:52
@sbrunner
Copy link
Member Author

Thanks @fredj

@sbrunner sbrunner merged commit cd90de2 into 2.0 May 24, 2016
@sbrunner sbrunner deleted the backaground-query branch May 24, 2016 14:45
tsauerwein
tsauerwein reviewed May 25, 2016
View reviewed changes
c2cgeoportal/views/entry.py
"type": server_ogc.type,
"imageType": server_ogc.image_type,
"auth": server_ogc.auth,
"wtsSupport": server_ogc.wfs_support,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be wfsSupport.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups, thanks :-)

@fredj
Copy link
Member

fredj commented May 25, 2016

@tsauerwein PR to come

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sbrunner @fredj @tsauerwein