-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add patching container for multiline input on ios #2979
Conversation
The mobile version of example app from this branch is ready! You can see it here |
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
The mobile version of example app from this branch is ready! You can see it here |
1 similar comment
The mobile version of example app from this branch is ready! You can see it here |
3403322
to
2e4f436
Compare
The mobile version of example app from this branch is ready! You can see it here |
Hi @lukewalczak I am having following result on iOS multiline input: Obviously the grey bar should not be there. |
@lukaszKowal-datasite thanks for feedback. Could you please send simple snack, to make it easier for me to debug it? |
@lukaszKowal-datasite @lukewalczak same issue for me, when there is no label on a TextInput then there is a grey box covering the actual text. |
Fixes: #2799
Summary
PR adds the absolutely positioned container which is kind of the patch for a TextInput to avoid covering input label with its value.
Test plan
TextInput
with propmultiline
height
in style