Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add patching container for multiline input on ios #2979

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Nov 12, 2021

Fixes: #2799

Summary

PR adds the absolutely positioned container which is kind of the patch for a TextInput to avoid covering input label with its value.

ios_multiline

Test plan

  1. Use TextInput with prop multiline
  2. Set height in style
  3. Type some text within input, which contains more space that set height
  4. Expect: input's value should not cover the label

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@callstack-bot
Copy link

callstack-bot commented Nov 15, 2021

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the fix/mutliline-ios-text-input branch from 3403322 to 2e4f436 Compare December 10, 2021 12:00
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit 6aa2c50 into main Dec 10, 2021
@lukewalczak lukewalczak deleted the fix/mutliline-ios-text-input branch December 10, 2021 12:09
@lukaszKowal-datasite
Copy link

Hi @lukewalczak
I think setting https://github.com/callstack/react-native-paper/pull/2979/files#diff-e4a748a69d38ea7aa878ad43d572a9e9b451e1cf72a5635c7e71112437e1a195R344
will manipulate theme colours?

I am having following result on iOS multiline input:
Simulator Screen Shot - iPhone 12 - 2021-12-15 at 16 18 59

Obviously the grey bar should not be there.

@lukewalczak
Copy link
Member Author

@lukaszKowal-datasite thanks for feedback. Could you please send simple snack, to make it easier for me to debug it?

@Svarto
Copy link
Contributor

Svarto commented Dec 26, 2021

@lukaszKowal-datasite @lukewalczak same issue for me, when there is no label on a TextInput then there is a grey box covering the actual text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS Only] mutline Textinput label is cover by text
4 participants