Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS Only] mutline Textinput label is cover by text #2799

Closed
KrifaYounes opened this issue Jul 3, 2021 · 7 comments · Fixed by #2979
Closed

[iOS Only] mutline Textinput label is cover by text #2799

KrifaYounes opened this issue Jul 3, 2021 · 7 comments · Fixed by #2979

Comments

@KrifaYounes
Copy link

KrifaYounes commented Jul 3, 2021

Capture d’écran 2021-07-03 à 17 05 33

here's a snack to reproduce the issue
https://snack.expo.io/@aknad/textinput

Only on iOS
It's ok on Android

latest version react-native-paper and react-native

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

Couldn't find version numbers for the following packages in the issue:

  • react-native
  • react-native-paper
  • react-native-vector-icons

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

@KrifaYounes KrifaYounes changed the title mutline Textinput label is cover by text [iOS Only] mutline Textinput label is cover by text Jul 3, 2021
@nicholascm
Copy link

nicholascm commented Jul 24, 2021

Hey @KrifaYounes - I was trying to reproduce this and I noticed that this only happens when there is a fixed height of the input (as you did in the snack). Is that a valid material design scenario?

If you just swap minHeight for height you can start the TextInput at the height you had specified, 100, and then as I see it, the input grows with the content properly without covering the label on iOS.

In the examples I see here , multiline inputs are growing with the length of the content.

@KrifaYounes
Copy link
Author

KrifaYounes commented Jul 26, 2021

Hey @KrifaYounes - I was trying to reproduce this and I noticed that this only happens when there is a fixed height of the input (as you did in the snack). Is that a valid material design scenario?

If you just swap minHeight for height you can start the TextInput at the height you had specified, 100, and then as I see it, the input grows with the content properly without covering the label on iOS.

In the examples I see here , multiline inputs are growing with the length of the content.

Hi @nicholascm ,
In android it's working fine and the textInput not cover the inputLabel.
It's not possible to reproduce the same result in iOS ?
I have a form with multiple fields and I don't want to increase height dynamically (minHeight), it's a bad idea if user input text is long for a mobile device.
Thanks

@nicholascm
Copy link

nicholascm commented Jul 26, 2021

I have a form with multiple fields and I don't want to increase height dynamically (minHeight), it's a bad idea if user input text is long for a mobile device.

Got it - and to be clear I'm not a maintainer or anything - just was trying to find a way to contribute to an open issue bug fix and wanted to be sure it was intended to be used that way before trying to fix it...I did see the exact behavior you mentioned on my iOS device, so it is definitely able to be reproduced.

@endronk
Copy link

endronk commented Oct 22, 2021

Any update on this?

This is a valid material design scenario. See the "Text area" part:
https://material.io/archive/guidelines/components/text-fields.html#text-fields-field-types
https://material.io/archive/guidelines/assets/0B8wSqcLwbhFuTHNXenJvVGhTRVk/textfields-textarea-01.mp4

Same thing also happened when I set the maxHeight property.

@lukewalczak
Copy link
Member

lukewalczak commented Nov 12, 2021

Hi, I've created a PR fixing it. You can try to install react-native-paper from PR's branch to check whether that fixes your issuse.

@KrifaYounes
Copy link
Author

Hi, I've created a PR fixing it. You can try to install react-native-paper from PR's branch to check whether that fixes your issuse.

it's working perfectly
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants