Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full width Chip touchable not focusing #2808

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

brunohkbx
Copy link
Collaborator

Summary

Resolve #2804.

Testing the web version I also realized that in larger resolutions the touchable was not filling all available space. I fixed that as well.

Before Web Before Mobile
web mobile

Test plan

Web Mobile
web mobile

@callstack-bot
Copy link

callstack-bot commented Jul 9, 2021

Hey @brunohkbx, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@brunohkbx brunohkbx force-pushed the fix/chip-touchable branch from ca2f256 to fed01af Compare July 9, 2021 20:17
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

The mobile version of example app from this branch is ready! You can see it here

.

@brunohkbx brunohkbx merged commit 7bdb7ac into main Jul 29, 2021
@brunohkbx brunohkbx deleted the fix/chip-touchable branch July 29, 2021 18:27
@dardinier
Copy link

Thank you for fixing this !
Is it possible to have a release including this fix please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full width Chips are not focusable anywhere on the chip
4 participants