Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full width Chips are not focusable anywhere on the chip #2804

Closed
dardinier opened this issue Jul 6, 2021 · 2 comments · Fixed by #2808
Closed

Full width Chips are not focusable anywhere on the chip #2804

dardinier opened this issue Jul 6, 2021 · 2 comments · Fixed by #2808

Comments

@dardinier
Copy link

Current behaviour

I have a Chip displayed in full width :

<Chip onPress={...}>Hello</Chip>

Sample : https://snack.expo.io/qeXIhkV_-

image

The chip is only pressable on the text and gets the focused state only around the text :

image

Expected behaviour

It should work like in previous versions :

https://snack.expo.io/ne1ESaMId

Here, when I press anywhere on the chip, the chip is focused and all the chip gets the focused state :

Default :

image

Pressed :

image

What have you tried

I tried to give a full width View as children with the text in it but it didn't work too.

Your Environment

software version
ios or android Android 10 (API level 29)
react-native 0.63.4
react-native-paper 4.7.2
node 14.11.0
npm or yarn yarn 1.22.5
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Couldn't find version numbers for the following packages in the issue:

  • react-native-vector-icons
  • npm

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • react-native (found: 0.63.4, latest: 0.64.2)
  • react-native-paper (found: 4.7.2, latest: 4.9.2)
  • yarn (found: 1.22.5, latest: 1.22.10)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@dardinier
Copy link
Author

Still doesn't work in the latest version 4.9.2 of react-native-paper :

https://snack.expo.io/iEnHfXuTH

I don't use react-native-vector-icons
I don't use npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant