Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Flat TextInput) - Input Text color is not matching with MD3 design #4250

Closed
ektaghag-eaton opened this issue Jan 2, 2024 · 1 comment · Fixed by #4259
Closed

(Flat TextInput) - Input Text color is not matching with MD3 design #4250

ektaghag-eaton opened this issue Jan 2, 2024 · 1 comment · Fixed by #4259
Assignees
Labels
question Question related to the library, not an issue TextInput

Comments

@ektaghag-eaton
Copy link

Ask your Question

In the latest version of react-native-paper, the input text color is onSurfaceVariant when the mode is flat. But as per MD3 design guidelines, it should be onSurface.

Is there any specific reason to use onSurfaceVariant instead of onSurface only for flat mode?

return theme.colors.onSurfaceVariant;

@ektaghag-eaton ektaghag-eaton added the question Question related to the library, not an issue label Jan 2, 2024
@lukewalczak lukewalczak self-assigned this Jan 8, 2024
@lukewalczak
Copy link
Member

Hey @ektaghag-eaton, I've noticed that Material Design in October 2023 reorganized their color structure, so there can be an option some colors have been updated. I'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Question related to the library, not an issue TextInput
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants