Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Flat TextInput) - Input Text Underline color is not matching with MD3 design #4252

Closed
ArshdeepSingh3-eaton opened this issue Jan 3, 2024 · 1 comment · Fixed by #4259
Closed

(Flat TextInput) - Input Text Underline color is not matching with MD3 design #4252

ArshdeepSingh3-eaton opened this issue Jan 3, 2024 · 1 comment · Fixed by #4259
Labels
question Question related to the library, not an issue

Comments

@ArshdeepSingh3-eaton
Copy link

Ask your Question

In the latest version of react-native-paper, the input text underline color is onSurface when the mode is flat. But as per MD3 design guidelines, it should be onSurfaceVariant.

Is there any specific reason to use onSurface instead of onSurfaceVariant only for flat mode?
@ArshdeepSingh3-eaton ArshdeepSingh3-eaton added the question Question related to the library, not an issue label Jan 3, 2024
@ArshdeepSingh3-eaton ArshdeepSingh3-eaton mentioned this issue Jan 3, 2024
Closed
@lukewalczak
Copy link
Member

Related: #4250 (comment)

@lukewalczak lukewalczak mentioned this issue Jan 8, 2024
Merged
@lukewalczak lukewalczak linked a pull request Jan 8, 2024 that will close this issue
fix: update input colors #4259
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Question related to the library, not an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update input colors callstack/react-native-paper
2 participants
@lukewalczak @ArshdeepSingh3-eaton