Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text field user input color #157

Closed
huayunh opened this issue Dec 21, 2023 · 3 comments · Fixed by #178
Closed

Text field user input color #157

huayunh opened this issue Dec 21, 2023 · 3 comments · Fixed by #178
Assignees
@ektaghag-eaton
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected

Comments

@huayunh
Copy link
Contributor

huayunh commented Dec 21, 2023

Describe the bug / expected behavior

the text users type into the text field feels very dim in dark theme.
image

Suggested fix

The correct color is on-surface for both light and dark theme.
@huayunh huayunh added bug Something not working as expected needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Dec 21, 2023
@ektaghag-eaton
Copy link
Contributor

BLUI-5075

@huayunh huayunh removed the needs-review Issues that we would like to revisit/review label Dec 22, 2023
@ektaghag-eaton ektaghag-eaton self-assigned this Dec 28, 2023
@ektaghag-eaton ektaghag-eaton mentioned this issue Dec 28, 2023
Closed
@ektaghag-eaton
Copy link
Contributor

ektaghag-eaton commented Jan 2, 2024 •
edited
Loading

In RNP

For Flat input, text mode color is onSurfaceVariant

For outlined text mode color is onSurface

@ektaghag-eaton
Copy link
Contributor

ektaghag-eaton commented Jan 2, 2024 •
edited
Loading

In RNP

For Flat input, text mode color is onSurfaceVariant

For outlined text mode color is onSurface

Logged an issue under question category : callstack/react-native-paper#4250

@ektaghag-eaton ektaghag-eaton mentioned this issue Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ektaghag-eaton ektaghag-eaton

Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix input color with textColor prop etn-ccis/blui-react-native-showcase-demo
2 participants
@huayunh @ektaghag-eaton