Webex integration

[aar2dee2]

What does this PR do?

Fixes #2744
/claim #2744

Environment: Staging(main branch) / Production

Type of change

• New feature (non-breaking change which adds functionality)

How should this be tested?

• Test A
• Test B

Checklist

• I haven't checked if my changes generate no new warnings
• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 4:16am
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 4:16am

[vercel]

@aar2dee2 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[aar2dee2]

Hi,

I'm using the Zoom integration as a reference for building the Webex integration.
The Oauth is working:

Screen.Recording.2023-03-09.at.5.24.17.PM.mov

1/ I'm trying to test creating a meeting, but there's a Prisma error in the event types table.

How should I fix this?

2/ I'm working on functionality for

• listing meetings
• creating a meeting
• updating a meeting
• deleting a meeting

Are any other functions required from the integration?

3/ Other TODOs

- Screenshots
- Tests
-What else should be there?

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[sean-brydon]

Hi,

I'm using the Zoom integration as a reference for building the Webex integration. The Oauth is working:

1/ I'm trying to test creating a meeting, but there's a Prisma error in the event types table.

How should I fix this?

2/ I'm working on functionality for

• listing meetings
• creating a meeting
• updating a meeting
• deleting a meeting

Are any other functions required from the integration?

3/ Other TODOs

- Screenshots
- Tests
-What else should be there?

Can you try running yarn clean && yarn dx in project root - looks like you might be missing a migration

Issue fixed now

[hariombalhara]

Suggested change

	9. Set the Redirect URI as `<Cal.com URL>/api/integrations/webex/callback` replacing Cal.com URL with the URI at which your application runs. Also add the `<Cal.com URL>/api/auth/callback/webex` in Redirect URIs to allow authentication.
	9. Set the Redirect URI as `<Cal.com URL>/api/integrations/webex/callback` replacing Cal.com URL with the URI at which your application runs.

/auth/callback is not needed

[hariombalhara]

LGTM now.

Tests:

• Verified that the meeting is successfully created in webex after following the steps.
• Meeting time in Webex is correct

[hariombalhara]

Yet to verify a change in the core booking flow

[hariombalhara]

I reverted this entire file and was still able to cancel the webex meeting by cancelling the booking

[aar2dee2]

@hariombalhara

the cancel booking behavior is not consistent for me. I reverted the file to the original code and am running into errors again while canceling the booking. The videoAdapter is not picked correctly from credentials. This results in the meeting getting deleted on cal, but not on Webex. I added logs in a couple of places to show this.

[hariombalhara]

Thanks @aar2dee2. Looks like some weird problem. But as I see it, it has nothing to do with your app. Let's keep it reverted for this PR.
I would let @alannnc or @joeauyeung take care of it as they have more knowledge about this flow and this should be a problem with all video apps including Zoom in this case.

[aar2dee2]

okay. thanks!

any other recommended changes?

[hariombalhara]

LGTM now !! It is in a mergeable state. I see that console.logs are still there instead of logger but that can be a followup PR.

Regarding that change in handleCancelBooking, that's a core change which shoould be tackled separately.

[aar2dee2]

thank you!!