Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-1651] Possible issue with delete meetings in Video Apps like Zoom #8831

Closed
hariombalhara opened this issue May 11, 2023 · 5 comments
Closed
Assignees
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync
Milestone

Comments

@hariombalhara
Copy link
Member

hariombalhara commented May 11, 2023

          The `credentialId` is set to the calendar's `credentialId` [here](https://github.com/calcom/cal.com/blob/main/packages/core/EventManager.ts#L141).

This does not cause errors in updateMeeting because the correct video credentials are obtained using getVideoCredentials.

However, the handleCancelBooking handler directly calls deleteMeeting in the videoClient and does not use getVideoCredentials to obtain the video integration credentials. Accordingly, no videoAdapter is found for deleteMeeting.

Originally posted by @aar2dee2 in #7651 (comment)

CAL-1651

@maige-app maige-app bot added the 🐛 bug Something isn't working label May 11, 2023
@hariombalhara hariombalhara changed the title Possible issue with delete meetings in Video Apps like Zoom [CAL-1651] Possible issue with delete meetings in Video Apps like Zoom May 11, 2023
@hariombalhara
Copy link
Member Author

@alannnc assigned this issue to you, let me know if someone else should take care of it.

@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label May 14, 2023
@aar2dee2
Copy link
Contributor

Happy to work on this. Please feel free to assign/share how you want to proceed.

@alannnc alannnc added this to the v3.0 milestone May 24, 2023
@alannnc
Copy link
Contributor

alannnc commented May 24, 2023

@aar2dee2 Assigned, please let me know if you still can work on this.
It looks like we should fetch credentials before calling deleteMeeting?

@aar2dee2
Copy link
Contributor

thanks @alannnc

I'd made a fix in one of the commits in the Webex app PR
See the packages/features/bookings/lib/handleCancelBooking.ts file here

Would that approach be suitable?

@PeerRich PeerRich modified the milestones: v3.0, v3.0 unfinished Jun 17, 2023
@PeerRich PeerRich modified the milestones: v3.0 unfinished, v3.1 Jun 26, 2023
@keithwillcode keithwillcode modified the milestones: v3.1, v3.2 Jun 29, 2023
@PeerRich PeerRich added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Jul 3, 2023
@alannnc
Copy link
Contributor

alannnc commented Jul 12, 2023

Solved here

#9281

@hariombalhara hariombalhara modified the milestones: v3.1, v3.2 Jul 12, 2023
@keithwillcode keithwillcode modified the milestones: v3.2, v3.1 Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

5 participants