Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: upgrade to Python 3.10 #120

Merged
merged 7 commits into from
Aug 15, 2022
Merged

Feat: upgrade to Python 3.10 #120

merged 7 commits into from
Aug 15, 2022

Conversation

thekaveman
Copy link
Member

Closes #112

Similar approach as in cal-itp/benefits#852

Also had to update the devcontainer startup, moving the command: sleep infinity to the entrypoint -- this aligns with how we have it configured in benefits.

@thekaveman
feat(python): update to Python 3.10
5a01e6a
@thekaveman
chore(docker): switch to non-root user sooner in build
5c0c80b
@thekaveman
chore(devcontainer): remove unnecessary package installs
81a4b3a 
we're no longer on the -slim variant, and the tools we were using
are included in the base image
@thekaveman
chore(devcontainer): move requirements to file
d878be8
@thekaveman
fix(devcontainer): swap back to non-root user
e76844c
@thekaveman
fix(devcontainer): move command to entrypoint
c373ad0 
was seeing an error on container startup that 'sleep' could
not be executed as a binary

this is how we have the devcontainer setup in benefits
@thekaveman thekaveman requested a review from a team as a code owner August 10, 2022 16:35
@thekaveman thekaveman modified the milestone: Courtesy Cards Aug 10, 2022
@thekaveman thekaveman self-assigned this Aug 10, 2022
@thekaveman thekaveman added this to the Courtesy Cards milestone Aug 10, 2022
@thekaveman thekaveman added dependencies Pull requests that update dependencies chore Chores and tasks for code cleanup, dev experience, etc. labels Aug 10, 2022
@thekaveman
Copy link
Member Author

@machikoyasuda can you take a look and make sure everything still runs on your machine?

  • Completely delete images / containers
  • Rebuild the server
  • Rebuild and Reopen the devcontainer
  • Edit a file / save / commit a change, verify that this works

machikoyasuda
machikoyasuda approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the following to test:

  • Delete all Docker images/containers
  • Pull the latest from this branch
  • Run docker compose build server
  • Open VSCode and Rebuild & Restart
  • Run the app
  • Check /healthcheck
  • Run python setup.py
  • Run tests
  • Edit/save a file
  • Confirm Python shell and version

@thekaveman thekaveman merged commit 33e6152 into main Aug 15, 2022
@thekaveman thekaveman deleted the feat/python-310 branch August 15, 2022 22:51
@angela-tran angela-tran mentioned this pull request Nov 14, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
chore Chores and tasks for code cleanup, dev experience, etc. dependencies Pull requests that update dependencies
Projects
None yet
Milestone
Courtesy Cards
Development

Successfully merging this pull request may close these issues.

Upgrade to Python 3.10
3 participants
@thekaveman @machikoyasuda @angela-tran