-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: upgrade to Python 3.10 #852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-tran
reviewed
Aug 5, 2022
0f178cd
to
1cc02dd
Compare
angela-tran
previously approved these changes
Aug 5, 2022
black was targeting python 3.8, update that as well
now we're using the python:3.10 image, instead of the -slim variant, so git is already included
* remove extra tools installed already by python:3.10 * remove unused jq tool, especially now that fixtures are gone * move requirements to file, install from there
1cc02dd
to
261ebc2
Compare
@angela-tran the UI tests were stuck for some reason. Force pushed. |
angela-tran
approved these changes
Aug 5, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #768
This PR goes from a base image of
python:3.9-slim
to now usingpython:3.10
.Because we're not using the
-slim
variant, a number of tools likecurl
,git
, andssh
, are already included - so we don't have to install them separately. The build process is a little simpler and faster as a result.