Footer: Add Compiler line #2460
Conversation
github-actions
bot
added
front-end
Coverage report
This PR does not seem to contain any modification to coverable code. |
| @@ -111,6 +111,9 @@ | |||
| <li> | |||
| <a class="footer-link m-0 p-0" href="https://cdt.ca.gov/privacy-policy/" target="_blank" rel="noopener noreferrer">{% translate "Privacy Policy" %}</a> | |||
| </li> | |||
| <li class="ms-auto"> | |||
There was a problem hiding this comment.
ms-auto means "margin start: auto", and "start" means left if the page is set to a language that reads from left to right.
How this works: https://stackoverflow.com/questions/33924655/position-last-flex-item-at-the-end-of-container
machikoyasuda
force-pushed
the
feat/2449-powered-by
branch
2 times, most recently
from
fd61000 to
738acac
Compare
machikoyasuda
force-pushed
the
feat/2449-powered-by
branch
from
738acac to
3e6ee60
Compare
| @@ -111,6 +111,9 @@ | |||
| <li> | |||
| <a class="footer-link m-0 p-0" href="https://cdt.ca.gov/privacy-policy/" target="_blank" rel="noopener noreferrer">{% translate "Privacy Policy" %}</a> | |||
| </li> | |||
| <li class="ms-auto"> | |||
| <a class="footer-link m-0 p-0" href="https://compiler.la" target="_blank" rel="noopener noreferrer">{% translate "Powered by Compiler LLC" %}</a> | |||
There was a problem hiding this comment.
Sorry, I didn't notice this in the design. I think the link text should not include the "Powered by" copy, that should come before/outside the link text.
This was what I wrote in the original ticket:
Use the following language:
Powered by Compiler LLC
There was a problem hiding this comment.
Updated to this:
I think it's a cleaner look to have the entire phrase be a link, and I don't see that being an issue with screenreaders either. HOWEVER, either way is fine by me.
There was a problem hiding this comment.
Hrm.. this is actually tricky because the footer links change color after they've been visited, but the "Powered by" would stay light blue. So the Powered by always stay light blue, and the Compiler LLC part changes to purple after it's been clicked:
Are we okay with this?
There was a problem hiding this comment.
I would expect the "Powered by" to be... white text? Making it the same color as the link feels strange.
There was a problem hiding this comment.
If this is too complicated, leaving the entire text as the link is fine.
There was a problem hiding this comment.
This is how it would look with white/purple visited link or white/blue unvisited link:
Hover:
Focus:
There was a problem hiding this comment.
Here's the commit for the white text + regular link change: 7d20a5b
|
Thanks for the last-minute updates. |
closes #2449