Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Powered by" link to application footer #2449

Closed
3 tasks done
thekaveman opened this issue Oct 10, 2024 · 11 comments · Fixed by #2460
Closed
3 tasks done

Add "Powered by" link to application footer #2449

thekaveman opened this issue Oct 10, 2024 · 11 comments · Fixed by #2460
Assignees
Labels
chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. design UX/UI research and tasks: Figma front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework

Comments

@thekaveman
Copy link
Member

thekaveman commented Oct 10, 2024

We'd like visitors to the Benefits application to understand who is behind the planning, design, development, and maintenance of the software. We can add a simple link to the application footer, visible on all screens in the app.

I suggest placement at the far right side of the footer, within the overall container, e.g.

Image

Use the following language:

Powered by Compiler LLC

Acceptance Criteria

  • Copy is translated to Spanish
  • Design for an additional footer link with the above text is done and handed-off to Dev
  • Dev implements the link in Benefits app footer

Additional context

Related to #2448

@thekaveman thekaveman added chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. design UX/UI research and tasks: Figma labels Oct 10, 2024
@thekaveman
Copy link
Member Author

@srhhnry this is definitely a stretch goal for this Sprint, so no rush. Initial assignment to you for a (hopefully) quick and simple design.

We will need to translate this copy as well.

@thekaveman thekaveman moved this from Todo to Stretch in Digital Services Oct 10, 2024
@thekaveman thekaveman added front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Oct 10, 2024
@srhhnry
Copy link

srhhnry commented Oct 11, 2024

Initial design on desktop: Image

I'll need to figure out a mobile solution though as it's not as clear how that would work. Will update when I have it.

@srhhnry
Copy link

srhhnry commented Oct 11, 2024

Update: Image

@machikoyasuda
Copy link
Member

@thekaveman @srhhnry Is this design done and ready for development for this sprint?

@thekaveman
Copy link
Member Author

I think we just need a translation for "Powered by" @machikoyasuda @srhhnry

@machikoyasuda machikoyasuda self-assigned this Oct 15, 2024
@machikoyasuda
Copy link
Member

Assigning myself for the dev tasks of this PR

@machikoyasuda machikoyasuda moved this from Stretch to In progress in Digital Services Oct 15, 2024
@machikoyasuda
Copy link
Member

machikoyasuda commented Oct 15, 2024

@srhhnry Please submit this albeit tiny translation request to BabbleOn, and I'll start getting the code-side started.

@srhhnry
Copy link

srhhnry commented Oct 16, 2024

Design is merged, copy is updated to Ditto and synced to Crowdin. I've also informed Salim of the new translation need.

@machikoyasuda
Copy link
Member

The Spanish translation is now live in Crowdin. From Salim: We were able to easily cover both using the TM so there is no charge for this one. Let me know if you need help with anything else. TM is Crowdin's "Translation Memory" feature: https://support.crowdin.com/translation-memory/

@srhhnry
Copy link

srhhnry commented Oct 17, 2024

The spanish translation is now synced to Ditto!

@thekaveman
Copy link
Member Author

@srhhnry see my review comment here: #2460 (comment)

Is it possible to make a slight change to the design?

@github-project-automation github-project-automation bot moved this from In progress to Done in Digital Services Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. design UX/UI research and tasks: Figma front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants