Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrollment Success: Desktop - Bring text/img closer together #1640

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 10, 2023

fix #1638

What this PR does

  • Remove offset-lg-1
  • Change col-lg-6 to col-lg-7
  • No changes to mobile

Screenshot

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner August 10, 2023 20:05
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 10, 2023
@machikoyasuda
Copy link
Member Author

@srhhnry How does the above page look?

I could also widen the text to be 7 columns, not 6. That looks like this:
image

@srhhnry
Copy link

srhhnry commented Aug 10, 2023

Second image looks more centered against the headline, so let's go that direction

@machikoyasuda machikoyasuda self-assigned this Aug 10, 2023
@machikoyasuda
Copy link
Member Author

@srhhnry Awesome - thank you. The 7-column/5-column grid combo matches Figma best:

image

@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 10, 2023
@machikoyasuda
Copy link
Member Author

Ready for engineering review @angela-tran

@machikoyasuda machikoyasuda merged commit 9c716ae into dev Aug 11, 2023
@machikoyasuda machikoyasuda deleted the fix/1638-enrollment-success--spacing branch August 11, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Enrollment Success - Desktop: Image spacing is off
3 participants