Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Enrollment Success - Desktop: Image spacing is off #1638

Closed
machikoyasuda opened this issue Aug 10, 2023 · 3 comments · Fixed by #1640
Closed

Bug: Enrollment Success - Desktop: Image spacing is off #1638

machikoyasuda opened this issue Aug 10, 2023 · 3 comments · Fixed by #1640
Assignees
Labels
bug Something isn't working

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Aug 10, 2023

Image should be 16px away from the text.

image
@machikoyasuda machikoyasuda added the bug Something isn't working label Aug 10, 2023
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Aug 10, 2023

@srhhnry How is this:

image image The way this is constructed: The text is in a 6-column width, image is in a 4-column width, and the columns are next to each other. Currently, on dev, there is a 1 column width _between_ them. But in the screenshots in this comment, the columns are now flush next to each other (plus the mandatory column gutters of 12px).

Should the image width be dynamic (widens to take up 4-column widths at all times), or static (set to 345px and never changes)?

@srhhnry
Copy link

srhhnry commented Aug 10, 2023

First screenshot looks like the body + image pairing is off-center to me--like it's pulling to the left side of the screen. Maybe centering to the headline?

As for the second question....I think static, as the image is round and at a certain width it will look too tall for the page.

@machikoyasuda
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants