-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Help copy - agency card #1560
Conversation
548b9c9
to
0b47a39
Compare
I'm not super sure about this PR... I was just following our pattern of using placeholders for variables that don't exist on models, but realistically, it'll be a while before we have another agency that this section applies to. So are we going to have another PR later that essentially reverts this one? |
Yeah this doesn't feel all that useful to introduce the placeholders when all this text is known for MST/Courtesy Cards. |
Maybe a change is to refactor the help page to optionally show that section, with a |
9245a1b
to
4efdcea
Compare
4efdcea
to
bc92aef
Compare
@thekaveman I took your suggestion to do this refactor instead of having placeholder-filled copy. I force-pushed a new set of commits to this branch, and this is ready for re-review |
This is looking really great otherwise! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Part of #1544
This PR does not change the copy for the "agency card" section of the Help page, but rather extracts that section out to be a template specified by the TransitAgency model.