Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language updates #11

Merged
merged 16 commits into from
Feb 18, 2021
Merged

Language updates #11

merged 16 commits into from
Feb 18, 2021

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Feb 6, 2021

Finished

  • Update English text based on recent feedback
  • Refactor code to mark all translatable (user-facing) strings
  • Introduce PO files for English and Spanish text
  • Implement language per-request detection and toggling via menu button

Outstanding

  • Update Spanish text with new translations, including missing translations
  • Add django-admin compilemessages to container startup sequence

Notes

This branch was made on top of the work in #9, which implements the remaining app screens.

This PR should not be merged until after #9.

Copy link

@krainboltgreene krainboltgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really loving this solution!

@thekaveman
Copy link
Member Author

Rebased to remove the now-merged commits from #9.

@thekaveman thekaveman marked this pull request as ready for review February 18, 2021 18:05
@thekaveman
Copy link
Member Author

Getting this into main and we'll open additional PRs with translation updates.

@thekaveman thekaveman merged commit 704f5a0 into main Feb 18, 2021
@thekaveman thekaveman deleted the language branch February 18, 2021 18:28
@thekaveman thekaveman mentioned this pull request Jul 31, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants