Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor msgids in PO files #1571

Closed
4 tasks done
thekaveman opened this issue Jul 31, 2023 · 0 comments · Fixed by #1626
Closed
4 tasks done

Refactor msgids in PO files #1571

thekaveman opened this issue Jul 31, 2023 · 0 comments · Fixed by #1626
Assignees
Labels
chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. i18n Copy: Language files or Django i18n framework

Comments

@thekaveman
Copy link
Member

thekaveman commented Jul 31, 2023

Historically, we've treated the msgid in PO files as more of an identifier for the text of the msgstr. This is not the default behavior of language files in Django, however: https://docs.djangoproject.com/en/4.2/topics/i18n/translation/

More typically, the msgid is the text copy in the default language of the site, and the msgstr is used to override the default in different languages.

We continue looking for ways to simplify management of the app copy, we should refactor our PO files to follow this standard model.

Needs #1581 to be completed first.

Todo

  • In the English PO file, replace all msgid with the corresponding text in the msgstr
  • In the app, replace all references to a prior msgid with the corresponding English text
  • Delete the Spanish PO file This isn't necessary
  • Run bin/makemessages.sh to regenerate the Spanish PO with new English msgid and blank msgstr
@thekaveman thekaveman converted this from a draft issue Jul 31, 2023
@thekaveman thekaveman added chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. i18n Copy: Language files or Django i18n framework labels Jul 31, 2023
@thekaveman thekaveman added this to the Copy Improvements milestone Jul 31, 2023
@thekaveman thekaveman moved this from Todo to Blocked in Digital Services Jul 31, 2023
@thekaveman thekaveman self-assigned this Aug 7, 2023
@thekaveman thekaveman moved this from Blocked to In Progress in Digital Services Aug 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Digital Services Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. i18n Copy: Language files or Django i18n framework
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant