Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddyhttp: Fix listener wrapper regression from #6573 #6599

Merged
merged 1 commit into from
Oct 1, 2024
Merged

caddyhttp: Fix listener wrapper regression from #6573 #6599

merged 1 commit into from
Oct 1, 2024

Conversation

MayCXC
Copy link
Contributor

@MayCXC MayCXC commented Oct 1, 2024

feat. a right side in TLS listener wrapper and more descriptive error handling in listen

@MayCXC MayCXC mentioned this pull request Oct 1, 2024
Merged
@francislavoie francislavoie added the bug 🐞 Something isn't working label Oct 1, 2024
@francislavoie
Copy link
Member

francislavoie commented Oct 1, 2024 •
edited
Loading

Thanks, that makes sense. Wrong order.

and more descriptive error handling in listen

I don't see this in the changeset? oh you mean by reordering it should bubble up a better error message. Okay sounds good.

@francislavoie francislavoie changed the title pass TestHTTPRedirectWrapperWithLargeUpload caddyhttp: Fix listener wrapper regression from #6573 Oct 1, 2024
@francislavoie francislavoie merged commit 0e829bc into caddyserver:master Oct 1, 2024
33 checks passed
@mholt
Copy link
Member

mholt commented Oct 1, 2024

Appreciate the maintenance! 😃

@BrewTestBot BrewTestBot mentioned this pull request Dec 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MayCXC @francislavoie @mholt