Skip to content

Commit

Permalink
caddyhttp: Fix listener wrapper regression from #6573 (#6599)
Browse files Browse the repository at this point in the history
  • Loading branch information
MayCXC authored Oct 1, 2024
1 parent 4b1a9b6 commit 0e829bc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions listeners.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,14 @@ func (na NetworkAddress) listen(ctx context.Context, portOffset uint, config net
}
}

if ln == nil {
return nil, fmt.Errorf("unsupported network type: %s", na.Network)
}

if err != nil {
return nil, err
}

if ln == nil {
return nil, fmt.Errorf("unsupported network type: %s", na.Network)
}

if IsUnixNetwork(na.Network) {
isAbstractUnixSocket := strings.HasPrefix(address, "@")
if !isAbstractUnixSocket {
Expand Down
10 changes: 5 additions & 5 deletions modules/caddyhttp/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -535,11 +535,6 @@ func (app *App) Start() error {
return fmt.Errorf("network '%s' cannot handle HTTP/1 or HTTP/2 connections", listenAddr.Network)
}

if useTLS {
// create TLS listener - this enables and terminates TLS
ln = tls.NewListener(ln, tlsCfg)
}

// wrap listener before TLS (up to the TLS placeholder wrapper)
var lnWrapperIdx int
for i, lnWrapper := range srv.listenerWrappers {
Expand All @@ -550,6 +545,11 @@ func (app *App) Start() error {
ln = lnWrapper.WrapListener(ln)
}

if useTLS {
// create TLS listener - this enables and terminates TLS
ln = tls.NewListener(ln, tlsCfg)
}

// finish wrapping listener where we left off before TLS
for i := lnWrapperIdx; i < len(srv.listenerWrappers); i++ {
ln = srv.listenerWrappers[i].WrapListener(ln)
Expand Down

0 comments on commit 0e829bc

Please sign in to comment.