Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement skin.hide_download_controls property #8529

Merged
merged 1 commit into from
May 31, 2022
Merged

Implement skin.hide_download_controls property #8529

merged 1 commit into from
May 31, 2022

Conversation

pvannierop
Copy link
Contributor

Implement new skin.hide_download_controls property

This property will control new front-end behavior that hides all download/copy-to-clipboard functionality (see this PR).

@pvannierop pvannierop self-assigned this Apr 20, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pvannierop pvannierop force-pushed the property_hide_download_controls branch from 16c1c86 to dc415bc Compare July 15, 2021 12:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stale
Copy link

stale bot commented Oct 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 13, 2021
@jjgao
Copy link
Member

jjgao commented Oct 17, 2021

@pvannierop what's the plan with this pr?

@stale stale bot removed the stale label Oct 17, 2021
@stale
Copy link

stale bot commented Jan 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 15, 2022
@stale stale bot closed this Jan 31, 2022
@pvannierop pvannierop reopened this Jan 31, 2022
@stale stale bot removed the stale label Jan 31, 2022
@stale
Copy link

stale bot commented May 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 1, 2022
@Kekananen
Copy link

Hello, also wondering what is going on on this PR. We will need to have this feature disabled in order to allow users access.

@stale stale bot removed the stale label May 5, 2022
@Luke-Sikina
Copy link
Member

Hello, @Kekananen

Looks like this PR slipped through the cracks - thanks for reminding us about it. I'll try to get this moved along. My guess is that this isn't merged because the corresponding frontend PR is in pretty rough shape. I'll talk to the developers who made that PR and see if we can find a path forward, and then update you on this thread.

inodb
inodb reviewed May 18, 2022
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on the language but looks good otherwise 👍

docs/portal.properties-Reference.md Show resolved Hide resolved
@pvannierop pvannierop force-pushed the property_hide_download_controls branch from cfdc712 to f899798 Compare May 25, 2022 07:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

inodb
inodb approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@inodb inodb merged commit 1dc7225 into cBioPortal:master May 31, 2022
@Luke-Sikina
Copy link
Member

@Kekananen,

This just got merged, so it will be a part of release v4.1.9, which will be available later today.

@Kekananen
Copy link

Absolutely fantastic! Thanks to all. This will help us immensely.

@jjgao jjgao mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke-Sikina Luke-Sikina Luke-Sikina approved these changes

@inodb inodb inodb approved these changes

@n1zea144 n1zea144 n1zea144 approved these changes

@kalletlak kalletlak Awaiting requested review from kalletlak

Assignees

@pvannierop pvannierop

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pvannierop @jjgao @Kekananen @Luke-Sikina @n1zea144 @inodb