Hide download controls #3716
Merged
Hide download controls #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
requested changes
May 17, 2021
| @@ -68,7 +69,10 @@ export default class PatientHeader extends React.Component< | |||
| <h5>{patient.id}</h5> | |||
| <ClinicalInformationPatientTable | |||
| showFilter={false} | |||
| showCopyDownload={false} | |||
| showCopyDownload={ | |||
| false && | |||
There was a problem hiding this comment.
false && anything === false
pvannierop
force-pushed
the
hide_download_options
branch
2 times, most recently
from
a38721f to
7ebc85b
Compare
|
@pvannierop there was some talk about whether we really wanted to disable download? |
pvannierop
force-pushed
the
hide_download_options
branch
2 times, most recently
from
1e38401 to
7c83adc
Compare
| marginLeft: 10, | ||
| }} | ||
| /> | ||
| {!AppConfig.serverConfig.skin_hide_download_controls && ( |
There was a problem hiding this comment.
showShouldDownloadAndCopyControls()?
| { | ||
| ]; | ||
|
|
||
| if (!AppConfig.serverConfig.skin_hide_download_controls) { |
There was a problem hiding this comment.
shouldShowDownloadandCopyControls()?
| /> | ||
| )} | ||
| {!this.hasNoSegmentData && | ||
| !AppConfig.serverConfig.skin_hide_download_controls && ( |
| @@ -205,15 +207,18 @@ export class ClinicalDataTab extends React.Component< | |||
| <Else> | |||
| <ClinicalDataTabTableComponent | |||
| initialItemsPerPage={20} | |||
| showCopyDownload={true} | |||
| showCopyDownload={ | |||
| @@ -479,6 +480,9 @@ export default class MutationMapper< | |||
| : undefined | |||
| } | |||
| legend={this.legendColorCodes} | |||
| showDownloadControls={ | |||
| !AppConfig.serverConfig.skin_hide_download_controls | |||
pvannierop
force-pushed
the
hide_download_options
branch
from
f05c1c9 to
1e543af
Compare
pvannierop
force-pushed
the
hide_download_options
branch
from
1e543af to
668b88e
Compare
pvannierop
force-pushed
the
hide_download_options
branch
2 times, most recently
from
db94e1e to
b2fea3e
Compare
|
@pvannierop gonna close this now. |
|
@pvannierop i closed this for housekeeping. |
Closed
pvannierop
force-pushed
the
hide_download_options
branch
4 times, most recently
from
3777c82 to
a57df61
Compare
|
@pvannierop is there a reason we don't just do this in one place inside of the component? THere is something called the React context api which would allow us access global config. It strikes me as a perfect usecase for this. |
|
@alisman I am not aware of this feature. Should we discuss how to do this? |
pvannierop
force-pushed
the
hide_download_options
branch
5 times, most recently
from
bf99e71 to
f90d864
Compare
alisman
reviewed
May 20, 2022
| @@ -1,2 +1,2 @@ | |||
| #export CBIOPORTAL_URL="http://www.cbioportal.org" | |||
| export CBIOPORTAL_URL="http://localhost:8080" | |||
There was a problem hiding this comment.
probably shouldn't commit this?
pvannierop
force-pushed
the
hide_download_options
branch
from
f5d2032 to
935e710
Compare
alisman
force-pushed
the
hide_download_options
branch
from
18e7074 to
8f1ae84
Compare
alisman
force-pushed
the
hide_download_options
branch
from
8f1ae84 to
2169f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide Download Controls
Feature description
This PR will hide all download and copy-to-clipboard options from cBioPortal. This behavior is controlled by a new skin_hide_download_controls property in serverConfig. The removed download options include:
Tests
Localdb-e2e tests are added that check occurrence of download/clipboard icons and of occurrence of the word download anywhere on the page. Also, test that check for new tabs appearing on Studies Overview, Results View, Study View, Patient View and Group Comparison are included (to warn the developer that the test coverage should be increased to cover the new tab).