Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend valid mRNA expression profile ids #7033

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Conversation

rmadupuri
Copy link
Contributor

Describe changes proposed in this pull request:

  • Added stable ids of new zscore(all sample) profiles.

Checks

  • Runs on heroku
  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@inodb inodb changed the title Added new genomic profiles Add new allowed MRNA expression genomic profiles Jan 21, 2020
@inodb inodb changed the title Add new allowed MRNA expression genomic profiles Extend valid MRNA expression profile ids Jan 21, 2020
@inodb inodb changed the title Extend valid MRNA expression profile ids Extend valid mRNA expression profile ids Jan 21, 2020
@inodb inodb merged commit 678476c into master Jan 21, 2020
@inodb inodb added the chore label Jan 30, 2020
@jjgao jjgao deleted the new_genomic_profiles branch April 27, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants