-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rfc85 dynamic virtual study #11040
Merged
+161
−4
Merged
Rfc85 dynamic virtual study #11040
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d42a586
Add isDynamic field to Virtual Study in Session Service
forus ca76700
Query sample IDs using Virtual Study View Filters is it's of dynamic …
forus cbab49a
Rename boolean varialbe name isDynamic -> dynamic
forus 1adca8c
Refactor dynamic virtual study population
forus 7c394bb
Fix code smells discovered by sonarlint
forus 001656a
Merge branch 'master' into rfc85-dynamic-virtual-study
forus 73a838c
Merge branch 'master' into rfc85-dynamic-virtual-study
forus eaf5546
Add web mvc test for fetching static and dynamic virtual studies
forus e7bf2af
Merge branch 'master' into rfc85-dynamic-virtual-study
forus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Quick question: will this be cached? If yes, how?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pieterlukasse this method is not cached, but
studyViewFilterApplier.apply(virtualStudyData.getStudyViewFilter());
is. I don't think we should cache this method as it'd be cheap transformation.