Rfc85 dynamic virtual study #11040
Merged
Rfc85 dynamic virtual study #11040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
code looks good to me. Thanks @forus !
I added two questions.
Comment on lines
+247
to
+252
| /** | ||
| * This method populates the `virtualStudyData` object with a new set of sample IDs retrieved as the result of executing a query based on virtual study view filters. | ||
| * It first applies the filters defined within the study view, runs the query to fetch the relevant sample IDs, and then updates the virtualStudyData to reflect these fresh results. | ||
| * This ensures that the virtual study contains the latest sample IDs. | ||
| * @param virtualStudyData | ||
| */ |
There was a problem hiding this comment.
Nice! Quick question: will this be cached? If yes, how?
There was a problem hiding this comment.
@pieterlukasse this method is not cached, but studyViewFilterApplier.apply(virtualStudyData.getStudyViewFilter()); is. I don't think we should cache this method as it'd be cheap transformation.
haynescd
reviewed
Oct 17, 2024
Comment on lines
254
to
274
| List<SampleIdentifier> sampleIdentifiers = studyViewFilterApplier.apply(virtualStudyData.getStudyViewFilter()); | ||
| Map<String, Set<String>> sampleIdsByStudyId = sampleIdentifiers | ||
| .stream() | ||
| .collect( | ||
| Collectors.groupingBy( | ||
| SampleIdentifier::getStudyId, | ||
| Collectors.mapping(SampleIdentifier::getSampleId, Collectors.toSet()))); | ||
| Set<VirtualStudySamples> virtualStudySamples = sampleIdsByStudyId.entrySet().stream().map(entry -> { | ||
| VirtualStudySamples vss = new VirtualStudySamples(); | ||
| vss.setId(entry.getKey()); | ||
| vss.setSamples(entry.getValue()); | ||
| return vss; | ||
| }).collect(Collectors.toSet()); |
There was a problem hiding this comment.
Opinion, but I would extract this into a function called extractVirtualStudySamples or something similar.
haynescd
reviewed
Oct 17, 2024
forus
force-pushed
the
rfc85-dynamic-virtual-study
branch
from
eda7367 to
1adca8c
Compare
- Use the constructor dep. injection - return value withou assigning it to a variable
haynescd
approved these changes
Nov 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR