chore(build): run 'verify-parser' goal on CI #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcoulon
force-pushed
the
Issue732_make_verify_parser
branch
from
0014575 to
2a56c45
Compare
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 75 75
Lines 5194 5194
=======================================
Hits 4415 4415
Misses 492 492
Partials 287 287 |
Add a step to run the `verify-parser` goal, but on Linux VM only, so we don't have any issue (ie, git diff) on Windows with the CRLF vs LF at the end of the lines. This will ensure that a PR includes the optimized parser when running on CI Fixes bytesparadise#732 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue732_make_verify_parser
branch
from
2a56c45 to
1681de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that a PR includes the optimized
parser when running on CI
Fixes #732
Signed-off-by: Xavier Coulon [email protected]