Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable make verify-parser during CI build #732

Closed
xcoulon opened this issue Jul 17, 2020 · 0 comments · Fixed by #733
Closed

enable make verify-parser during CI build #732

xcoulon opened this issue Jul 17, 2020 · 0 comments · Fixed by #733

Comments

@xcoulon
Copy link
Member

xcoulon commented Jul 17, 2020

the make build goal should pre-run verify-parser to make sure that a PR includes the optimized grammar built with the latest version of pigeon.

@xcoulon xcoulon added this to the v0.5.0 milestone Jul 17, 2020
@xcoulon xcoulon changed the title enable make verify-parser during build enable make verify-parser during CI build Jul 17, 2020
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 17, 2020
This will ensure that a PR includes the optimized
parser when running on CI

Fixes bytesparadise#732

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 17, 2020
This will ensure that a PR includes the optimized
parser when running on CI

Fixes bytesparadise#732

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jul 17, 2020
Add a step to run the `verify-parser` goal, but on
Linux VM only, so we don't have any issue (ie, git diff)
on Windows with the CRLF vs LF at the end of the lines.

This will ensure that a PR includes the optimized
parser when running on CI

Fixes bytesparadise#732

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Jul 17, 2020
Add a step to run the `verify-parser` goal, but on
Linux VM only, so we don't have any diff result when
running `git diff` on Windows because of the 
CRLF vs LF at the end of the lines.

This will ensure that a PR includes the optimized
parser when running on CI

Fixes #732

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant