Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(renderer): lazy loading of templates #1062

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 26, 2022

Fixes #1061

Signed-off-by: Xavier Coulon [email protected]

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #1062 (d42ce47) into master (745e403) will increase coverage by 0.70%.
The diff coverage is 83.22%.

@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
+ Coverage   80.61%   81.32%   +0.70%     
==========================================
  Files          85       85              
  Lines        7167     7454     +287     
==========================================
+ Hits         5778     6062     +284     
- Misses        871      876       +5     
+ Partials      518      516       -2     

@github-actions
Copy link

github-actions bot commented Jun 26, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              27.1ms ± 1%    26.6ms ± 1%  -1.66%  (p=0.001 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    69.8ms ± 3%    68.1ms ± 1%  -2.52%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           73.9ms ± 1%    73.8ms ± 1%    ~     (p=0.297 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.8MB ± 0%    10.8MB ± 0%    ~     (p=0.258 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    27.2MB ± 0%    27.2MB ± 0%    ~     (p=1.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           25.0MB ± 0%    25.0MB ± 0%    ~     (p=0.222 n=9+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                126k ± 0%      126k ± 0%    ~     (p=0.248 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2      341k ± 0%      341k ± 0%    ~     (p=0.725 n=10+10)
RealDocumentProcessing/mocking.adoc-2             374k ± 0%      374k ± 0%    ~     (p=0.262 n=9+9)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              17.5ms ± 1%    26.6ms ± 1%  +51.94%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    50.8ms ± 1%    68.1ms ± 1%  +34.01%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           50.6ms ± 1%    73.8ms ± 1%  +45.70%  (p=0.000 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              8.85MB ± 0%   10.80MB ± 0%  +22.07%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    24.0MB ± 0%    27.2MB ± 0%  +13.31%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           21.6MB ± 0%    25.0MB ± 0%  +15.64%  (p=0.000 n=10+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                106k ± 0%      126k ± 0%  +18.79%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2      305k ± 0%      341k ± 0%  +11.73%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             326k ± 0%      374k ± 0%  +14.47%  (p=0.000 n=9+9)

@xcoulon xcoulon force-pushed the lazy_template_loading branch from fe4500c to d42ce47 Compare June 26, 2022 13:15
@xcoulon xcoulon merged commit 9f09049 into bytesparadise:master Jun 26, 2022
@xcoulon xcoulon deleted the lazy_template_loading branch June 26, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazy loading of templates
1 participant