Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy loading of templates #1061

Closed
xcoulon opened this issue Jun 26, 2022 · 0 comments · Fixed by #1062
Closed

lazy loading of templates #1061

xcoulon opened this issue Jun 26, 2022 · 0 comments · Fixed by #1062
Assignees
@xcoulon
Labels
type/refactor
Milestone
v0.8.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Jun 26, 2022

For simple documents, there is no need to initialize ALL templates. Using the sync.Once to load templates "on-demand", i.e., on the first time they are invoked, should increase perfs.
@xcoulon xcoulon added this to the v0.8.0 milestone Jun 26, 2022
@xcoulon xcoulon self-assigned this Jun 26, 2022
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jun 26, 2022
@xcoulon
refactor(renderer): lazy loading of templates
fe4500c 
Fixes bytesparadise#1061

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Jun 26, 2022
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jun 26, 2022
@xcoulon
refactor(renderer): lazy loading of templates
d42ce47 
Fixes bytesparadise#1061

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Jun 26, 2022
@xcoulon
refactor(renderer): lazy loading of templates (#1062)
9f09049 
Fixes #1061

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
type/refactor
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

refactor(renderer): lazy loading of templates xcoulon/libasciidoc
1 participant
@xcoulon