Start requiring f32/f64 in WIT by default #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
approved these changes
Sep 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This commit continues the transition started in bytecodealliance#1364 to rename the `float32 `and `float64` types in WIT to `f32` and `f64`. Now that support has been present for some time to parse `f32` and `f64` this commit flips the WIT parser to requiring it by default. The error message for `float32` and `float64` has additionally been updated to explain a bit more about this transition.
alexcrichton
force-pushed
the
require-f32-and-f64
branch
from
09ce878 to
a0431b9
Compare
Merged
via the queue into
bytecodealliance:main
with commit Sep 12, 2024
de9369c
31 of 60 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit continues the transition started in #1364 to rename the
float32andfloat64types in WIT tof32andf64. Now that support has been present for some time to parsef32andf64this commit flips the WIT parser to requiring it by default. The error message forfloat32andfloat64has additionally been updated to explain a bit more about this transition.